From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v6 1/8] RDMA/rxe: Replace RB tree by xarray for indexes
Date: Tue, 7 Dec 2021 15:09:47 -0400 [thread overview]
Message-ID: <20211207190947.GH6385@nvidia.com> (raw)
In-Reply-To: <20211206211242.15528-2-rpearsonhpe@gmail.com>
On Mon, Dec 06, 2021 at 03:12:36PM -0600, Bob Pearson wrote:
> if (pool->flags & RXE_POOL_INDEX) {
> - pool->index.tree = RB_ROOT;
> - err = rxe_pool_init_index(pool, info->max_index,
> - info->min_index);
> - if (err)
> - goto out;
> + xa_init_flags(&pool->xarray.xa, XA_FLAGS_ALLOC);
> + pool->xarray.limit.max = info->max_index;
> + pool->xarray.limit.min = info->min_index;
> + } else {
> + /* if pool not indexed just use xa spin_lock */
> + spin_lock_init(&pool->xarray.xa.xa_lock);
xarray's don't cost anything to init, so there is no reason to do
something like this.
> +/* drop a reference to an object */
> +static inline bool __rxe_drop_ref(struct rxe_pool_elem *elem)
> +{
> + bool ret;
> +
> + rxe_pool_lock_bh(elem->pool);
> + ret = kref_put(&elem->ref_cnt, rxe_elem_release);
> + rxe_pool_unlock_bh(elem->pool);
This is a bit strange, why does something need to hold a lock around a
kref?
Jason
next prev parent reply other threads:[~2021-12-07 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 21:12 [PATCH for-next v6 0/8] RDMA/rxe: Correct race conditions Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 1/8] RDMA/rxe: Replace RB tree by xarray for indexes Bob Pearson
2021-12-07 19:09 ` Jason Gunthorpe [this message]
2021-12-09 0:16 ` Bob Pearson
2021-12-09 0:18 ` Jason Gunthorpe
2021-12-09 0:26 ` Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 2/8] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 3/8] RDMA/rxe: Cleanup pool APIs for keyed objects Bob Pearson
2021-12-07 19:18 ` Jason Gunthorpe
2021-12-06 21:12 ` [PATCH for-next v6 4/8] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 5/8] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 6/8] RDMA/rxe: Minor cleanups in rxe_pool.c/rxe_pool.h Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 7/8] RDMA/rxe: Replace rxe_alloc by kzalloc for rxe_mc_elem Bob Pearson
2021-12-06 21:12 ` [PATCH for-next v6 8/8] RDMA/rxe: Add wait for completion to obj destruct Bob Pearson
2021-12-07 19:28 ` Jason Gunthorpe
2021-12-08 21:21 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207190947.GH6385@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).