Re: [PATCH for-next v14 00/10] Fix race conditions in rxe_pool

From: Jason Gunthorpe <jgg@nvidia.com>
To: Yanjun Zhu <yanjun.zhu@linux.dev>
Cc: Bob Pearson <rpearsonhpe@gmail.com>,
	zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v14 00/10] Fix race conditions in rxe_pool
Date: Tue, 10 May 2022 09:43:51 -0300	[thread overview]
Message-ID: <20220510124351.GX49344@nvidia.com> (raw)
In-Reply-To: <a52a0cc3-7f29-05f3-04f3-585483cd5d1d@linux.dev>

On Tue, May 10, 2022 at 08:35:34AM +0800, Yanjun Zhu wrote:
> 在 2022/5/10 2:23, Jason Gunthorpe 写道:
> > On Wed, Apr 20, 2022 at 08:40:33PM -0500, Bob Pearson wrote:
> > 
> > > Bob Pearson (10):
> > >    RDMA/rxe: Remove IB_SRQ_INIT_MASK
> > >    RDMA/rxe: Add rxe_srq_cleanup()
> > >    RDMA/rxe: Check rxe_get() return value
> > >    RDMA/rxe: Move qp cleanup code to rxe_qp_do_cleanup()
> > >    RDMA/rxe: Move mr cleanup code to rxe_mr_cleanup()
> > >    RDMA/rxe: Move mw cleanup code to rxe_mw_cleanup()
> > >    RDMA/rxe: Enforce IBA C11-17
> > 
> > I took these patches with the small edits I noted
> > 
> > >    RDMA/rxe: Stop lookup of partially built objects
> > >    RDMA/rxe: Convert read side locking to rcu
> > >    RDMA/rxe: Cleanup rxe_pool.c
> > 
> > It seems OK, but we need to fix the AH problem at least in the destroy
> > path first - lets try to fix it in alloc as well?
> 
> I do not mean to bring more efforts to Bob.
> But normally a new feature is merged into rdma. some test cases should also
> be added to rdma-core to verify this new feature.

It isn't a feature.

Jason