From: Li Zhijian <lizhijian@fujitsu.com>
To: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Li Zhijian <lizhijian@fujitsu.com>,
Bob Pearson <rpearsonhpe@gmail.com>
Subject: [PATCH jgg-for-next] RDMA/rxe: Fix pd refcount_t: underflow; use-after-free
Date: Tue, 27 Sep 2022 13:25:30 +0800 [thread overview]
Message-ID: <20220927052530.21397-1-lizhijian@fujitsu.com> (raw)
In the error path, both rxe_put(pd) and rxe_cleanup(mr) will
drop pd's ref_cont.
rxe_cleanup(mr)
-> __rxe_cleanup
-> rxe_put(mr->elem)
-> rxe_mr_cleanup(mr)
-> rxe_put(mr_pd(mr))
[342431.583189] ------------[ cut here ]------------
[342431.585051] refcount_t: underflow; use-after-free.
[342431.586677] WARNING: CPU: 0 PID: 660500 at lib/refcount.c:28 refcount_warn_saturate+0xcd/0x120
[342431.605247] RIP: 0010:refcount_warn_saturate+0xcd/0x120
[342431.661981] __rxe_cleanup+0x1c3/0x1e0 [rdma_rxe]
[342431.663260] rxe_dealloc_pd+0x16/0x20 [rdma_rxe]
[342431.664883] ib_dealloc_pd_user+0x95/0xd0 [ib_core]
[342431.666803] destroy_hw_idr_uobject+0x46/0x90 [ib_uverbs]
[342431.668514] uverbs_destroy_uobject+0xc8/0x360 [ib_uverbs]
[342431.670232] __uverbs_cleanup_ufile+0x157/0x210 [ib_uverbs]
[342431.671920] ? uverbs_destroy_uobject+0x360/0x360 [ib_uverbs]
CC: Bob Pearson <rpearsonhpe@gmail.com>
Fixes: 0d0e4b528c3b ("RDMA/rxe: Set pd early in mr alloc routines")
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
I have to say i made a mistake in previous review, I missed this WARN_ONCE messages.
And the V6 patch that i had applied fix this problem in another way.
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index 933277d67b7c..88825edc7dce 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -939,7 +939,6 @@ static struct ib_mr *rxe_reg_user_mr(struct ib_pd *ibpd,
return &mr->ibmr;
err3:
- rxe_put(pd);
rxe_cleanup(mr);
err2:
return ERR_PTR(err);
@@ -974,7 +973,6 @@ static struct ib_mr *rxe_alloc_mr(struct ib_pd *ibpd, enum ib_mr_type mr_type,
return &mr->ibmr;
err2:
- rxe_put(pd);
rxe_cleanup(mr);
err1:
return ERR_PTR(err);
--
2.31.1
next reply other threads:[~2022-09-27 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 5:25 Li Zhijian [this message]
2022-09-27 13:14 ` [PATCH jgg-for-next] RDMA/rxe: Fix pd refcount_t: underflow; use-after-free Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927052530.21397-1-lizhijian@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).