From: Bjorn Helgaas <helgaas@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: Saurabh Singh Sengar <ssengar@microsoft.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Jake Oshins <jakeo@microsoft.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"kw@linux.com" <kw@linux.com>, KY Srinivasan <kys@microsoft.com>,
"leon@kernel.org" <leon@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh@kernel.org" <robh@kernel.org>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Long Li <longli@microsoft.com>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [EXTERNAL] [PATCH 1/6] PCI: hv: fix a race condition bug in hv_pci_query_relations()
Date: Tue, 28 Mar 2023 12:24:45 -0500 [thread overview]
Message-ID: <20230328172445.GA2951931@bhelgaas> (raw)
In-Reply-To: <SA1PR21MB133553326FBAD376DE9DB48ABF889@SA1PR21MB1335.namprd21.prod.outlook.com>
On Tue, Mar 28, 2023 at 05:38:59AM +0000, Dexuan Cui wrote:
> > From: Saurabh Singh Sengar <ssengar@microsoft.com>
> > Sent: Monday, March 27, 2023 10:29 PM
> > > ...
> > > ---
>
> Please note this special line "---".
> Anything after the special line and before the line "diff --git" is discarded
> automaticaly by 'git' and 'patch'.
>
> > > drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > @@ -3635,6 +3641,8 @@ static int hv_pci_probe(struct hv_device *hdev,
> > >
> > > retry:
> > > ret = hv_pci_query_relations(hdev);
> > > + printk("hv_pci_query_relations() exited\n");
> >
> > Can we use pr_* or the appropriate KERN_<LEVEL> in all the printk(s).
>
> This is not part of the real patch :-)
> I just thought the debug code can help understand the issues
> resolved by the patches.
> I'll remove the debug code to avoid confusion if I need to post v2.
I guess that means you *will* post a v2, right? Or do you expect
somebody else to remove the debug code? If you do keep any debug or
other logging, use pci_info() (or dev_info()) whenever possible.
Also capitalize the subject line to match the others in the series.
Bjorn
next prev parent reply other threads:[~2023-03-28 17:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 4:51 [PATCH 0/6] pci-hyper: fix race condition bugs for fast device hotplug Dexuan Cui
2023-03-28 4:51 ` [PATCH 1/6] PCI: hv: fix a race condition bug in hv_pci_query_relations() Dexuan Cui
2023-03-28 5:29 ` [EXTERNAL] " Saurabh Singh Sengar
2023-03-28 5:38 ` Dexuan Cui
2023-03-28 17:24 ` Bjorn Helgaas [this message]
2023-03-29 8:37 ` Dexuan Cui
2023-03-29 16:06 ` Bjorn Helgaas
2023-03-28 16:48 ` Long Li
2023-03-29 8:21 ` Dexuan Cui
2023-03-28 4:51 ` [PATCH 2/6] PCI: hv: Fix a race condition in hv_irq_unmask() that can cause panic Dexuan Cui
2023-03-28 4:51 ` [PATCH 3/6] PCI: hv: Remove the useless hv_pcichild_state from struct hv_pci_dev Dexuan Cui
2023-03-28 4:51 ` [PATCH 4/6] Revert "PCI: hv: Fix a timing issue which causes kdump to fail occasionally" Dexuan Cui
2023-03-28 6:33 ` Dexuan Cui
2023-03-28 12:46 ` Wei Hu
2023-03-30 5:17 ` Wei Hu
2023-03-28 4:51 ` [PATCH 5/6] PCI: hv: Add a per-bus mutex state_lock Dexuan Cui
2023-03-29 16:41 ` Michael Kelley (LINUX)
2023-03-29 16:54 ` Dexuan Cui
2023-03-28 4:51 ` [PATCH 6/6] PCI: hv: Use async probing to reduce boot time Dexuan Cui
2023-03-29 16:55 ` Michael Kelley (LINUX)
2023-03-29 22:42 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328172445.GA2951931@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=boqun.feng@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jakeo@microsoft.com \
--cc=kuba@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=lpieralisi@kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saeedm@nvidia.com \
--cc=ssengar@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).