From: Joel Granados <j.granados@samsung.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <Dai.Ngo@oracle.com>, <alex.aring@gmail.com>,
<alibuda@linux.alibaba.com>, <allison.henderson@oracle.com>,
<anna@kernel.org>, <bridge@lists.linux.dev>,
<chuck.lever@oracle.com>, <coreteam@netfilter.org>,
<courmisch@gmail.com>, <davem@davemloft.net>,
<dccp@vger.kernel.org>,
<devnull+j.granados.samsung.com@kernel.org>,
<dhowells@redhat.com>, <dsahern@kernel.org>,
<edumazet@google.com>, <fw@strlen.de>, <geliang@kernel.org>,
<guwen@linux.alibaba.com>, <herbert@gondor.apana.org.au>,
<horms@verge.net.au>, <ja@ssi.bg>, <jaka@linux.ibm.com>,
<jlayton@kernel.org>, <jmaloy@redhat.com>, <jreuter@yaina.de>,
<kadlec@netfilter.org>, <keescook@chromium.org>,
<kolga@netapp.com>, <kuba@kernel.org>,
<linux-afs@lists.infradead.org>, <linux-hams@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<linux-sctp@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
<linux-x25@vger.kernel.org>, <lucien.xin@gmail.com>,
<lvs-devel@vger.kernel.org>, <marc.dionne@auristor.com>,
<marcelo.leitner@gmail.com>, <martineau@kernel.org>,
<matttbe@kernel.org>, <mcgrof@kernel.org>,
<miquel.raynal@bootlin.com>, <mptcp@lists.linux.dev>,
<ms@dev.tdt.de>, <neilb@suse.de>, <netdev@vger.kernel.org>,
<netfilter-devel@vger.kernel.org>, <pabeni@redhat.com>,
<pablo@netfilter.org>, <ralf@linux-mips.org>,
<razor@blackwall.org>, <rds-devel@oss.oracle.com>,
<roopa@nvidia.com>, <stefan@datenfreihafen.org>,
<steffen.klassert@secunet.com>,
<tipc-discussion@lists.sourceforge.net>, <tom@talpey.com>,
<tonylu@linux.alibaba.com>, <trond.myklebust@hammerspace.com>,
<wenjia@linux.ibm.com>, <ying.xue@windriver.com>
Subject: Re: [PATCH v2 4/4] ax.25: Remove the now superfluous sentinel elements from ctl_table array
Date: Fri, 12 Apr 2024 16:50:00 +0200 [thread overview]
Message-ID: <20240412145000.4nrf5sufnwjltdl4@joelS2.panther.com> (raw)
In-Reply-To: <20240405222658.3615-1-kuniyu@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]
On Fri, Apr 05, 2024 at 03:26:58PM -0700, Kuniyuki Iwashima wrote:
> From: Joel Granados <j.granados@samsung.com>
> Date: Fri, 5 Apr 2024 09:15:31 +0200
> > On Thu, Mar 28, 2024 at 12:49:34PM -0700, Kuniyuki Iwashima wrote:
> > > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kernel.org>
> > > Date: Thu, 28 Mar 2024 16:40:05 +0100
> > > > This commit comes at the tail end of a greater effort to remove the
> > > > empty elements at the end of the ctl_table arrays (sentinels) which will
> > > > reduce the overall build time size of the kernel and run time memory
> > > > bloat by ~64 bytes per sentinel (further information Link :
> > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > > >
> > > > When we remove the sentinel from ax25_param_table a buffer overflow
> > > > shows its ugly head. The sentinel's data element used to be changed when
> > > > CONFIG_AX25_DAMA_SLAVE was not defined.
> > >
> > > I think it's better to define the relation explicitly between the
> > > enum and sysctl table by BUILD_BUG_ON() in ax25_register_dev_sysctl()
> > >
> > > BUILD_BUG_ON(AX25_MAX_VALUES != ARRAY_SIZE(ax25_param_table));
> > >
> > > and guard AX25_VALUES_DS_TIMEOUT with #ifdef CONFIG_AX25_DAMA_SLAVE
> > > as done for other enum.
> >
> > When I remove AX25_VALUES_DS_TIMEOUT from the un-guarded build it
> > complains in net/ax25/ax25_ds_timer.c (ax25_ds_set_timer). Here is the
> > report https://lore.kernel.org/oe-kbuild-all/202404040301.qzKmVQGB-lkp@intel.com/.
> >
> > How best to address this? Should we just guard the whole function and do
> > nothing when not set? like this:
>
> It seems fine to me.
>
> ax25_ds_timeout() checks !ax25_dev->dama.slave_timeout, but it's
> initialised by kzalloc() during dev setup, so it will be a noop.
Just sent v3 with this change.
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-04-15 6:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 15:40 [PATCH v2 0/4] sysctl: Remove sentinel elements from networking Joel Granados via B4 Relay
2024-03-28 15:40 ` [PATCH v2 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-03-28 15:40 ` [PATCH v2 2/4] netfilter: " Joel Granados via B4 Relay
2024-03-28 15:40 ` [PATCH v2 3/4] appletalk: " Joel Granados via B4 Relay
2024-03-28 15:40 ` [PATCH v2 4/4] ax.25: " Joel Granados via B4 Relay
2024-03-28 19:49 ` Kuniyuki Iwashima
2024-04-03 9:16 ` Joel Granados
2024-04-03 10:59 ` Joel Granados
2024-04-05 7:15 ` Joel Granados
2024-04-05 22:26 ` Kuniyuki Iwashima
2024-04-08 7:20 ` Joel Granados
2024-04-12 14:50 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412145000.4nrf5sufnwjltdl4@joelS2.panther.com \
--to=j.granados@samsung.com \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=alibuda@linux.alibaba.com \
--cc=allison.henderson@oracle.com \
--cc=anna@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=chuck.lever@oracle.com \
--cc=coreteam@netfilter.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=devnull+j.granados.samsung.com@kernel.org \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=guwen@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=jaka@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jmaloy@redhat.com \
--cc=jreuter@yaina.de \
--cc=kadlec@netfilter.org \
--cc=keescook@chromium.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=lvs-devel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=marcelo.leitner@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mcgrof@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mptcp@lists.linux.dev \
--cc=ms@dev.tdt.de \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=ralf@linux-mips.org \
--cc=razor@blackwall.org \
--cc=rds-devel@oss.oracle.com \
--cc=roopa@nvidia.com \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tom@talpey.com \
--cc=tonylu@linux.alibaba.com \
--cc=trond.myklebust@hammerspace.com \
--cc=wenjia@linux.ibm.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).