From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC118563D for ; Fri, 19 Apr 2024 12:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528841; cv=none; b=SueVM4agOPvvV/pFioYVT6RS2wGek0ajMTcA91PSuvVeG5c5cMMZVBev3jZXjHMS4DDS71UJ+6mWGxmnkG2CfXvFcBcHdWaTIiXOLZYeQhyhAfmB+ZQ4OU0TtUug8g2gisug5iuOQSQHL5pF7M1ZOh2op3CbP78vR5rd2kr33y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713528841; c=relaxed/simple; bh=ExrFTBEMLysOlFee1rplMJqRkLcyI8BEBxqM1v/q8vw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJdieT48hMzi4ThfeOLeEwAwSY3QB4PTRT1ZDtxoQ+E589udGfN1H6cCrvG5b2PAhRChSkbCHNXpqF5WI3wleUU3Nrf0cXkwrcuJ0cxjD8OX9pcTlSVscfhrfaqeIuyDwLbNiE5b7a6yGlpAYZnStcSEdpdMoIZGTt4Y5zxpDPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=d/Ym2Roc; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="d/Ym2Roc" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6eb86aeeb2cso1067894a34.3 for ; Fri, 19 Apr 2024 05:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1713528839; x=1714133639; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hClZeCrWEscg3J5h83DbwJ64WLBmvjGwEZ7n9vuYDf0=; b=d/Ym2RocXeUfT4NSLSANYFCbVNbq4JWuZJSHDzT31qCrFN/rJ+0KM29vaVzNTcgmLa TziCCiv3FvYHNIDuYz/RAwnIdtsXFvqSW6sjcEgRsM5U2l7zknedscv6zl+NaFsljGNy i3dFHEbgF8JZFAQlIV20NW6EmMOl890DL8qIDu544YnrfBSba7JNjtXZXp4PsJyuVxwi 8RkQM9pgn1Q4J5YAb9ywUFVpus06Dk4m1L0kk6JINvQoM3M09a/+TMNG631EnlEW7fl8 VXQvkIPHpCIDA5SFP6OzMTtQg97Fv5t1nq+OaYem5Q0mTQ5ww3DHZTpucQbEI4mJw9A3 JO8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713528839; x=1714133639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hClZeCrWEscg3J5h83DbwJ64WLBmvjGwEZ7n9vuYDf0=; b=GlyAJEdkG962us+XIg9ZYiJiBVXo5ZNp/qZ3aSFDvqgSsOuFrwO5PnLW+CEr9QjJv0 L2M4nqiiSZOZ8pCH0apL3qnrN+5RrBfJUcQD6AU2NMggsVeQHbB8kQHFeNovCWv7MkX5 vmFyedTiuIgQFtTSxHO2ASb9swr96G66coyS8kMnAIuXVNr8pPR6kIZMKEjwG9W+eDpp TVmWok1sL8zIYM/LHtUaX/RoQj/SQSFKRpkNeEtRfjVtCaiPnSt4fTqNO2r5MTOjv1zm ycnuPqYhmQeeiVs890wBkiJ2xkqdX+pqt9XQlv7aMWAKc3AgvaCpEG/OXj52fv3fx+SX uuTA== X-Forwarded-Encrypted: i=1; AJvYcCUZ1bgBUcBjvS4IHWXJv/fFZM2qU3fe3Uz3mUFvDjCsmt/0k88H4VpTptswgaKtRh6Wf5I3uyXzq4r68cMjzmp3IFoaaZj09Q6iGg== X-Gm-Message-State: AOJu0YwsjJWwEQuxJ4JmGZV/BDoLwwQyc20d48IIGqtnxOebfVQC+dwY CP+jEbc9X8zXqoj0jpai3JZSOU/PqT0HqbB7haLHPYB6MWje2RjfMGImLC63My0= X-Google-Smtp-Source: AGHT+IFXe1Uvgf42Jw4ozBKiARbrTyiKg6q2CPN8avKsqmplfA08fWwIoKVSuopw8vPdavC70O3dLA== X-Received: by 2002:a05:6830:7306:b0:6eb:d6f0:fed5 with SMTP id ex6-20020a056830730600b006ebd6f0fed5mr1195950otb.6.1713528839059; Fri, 19 Apr 2024 05:13:59 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id b8-20020a056830104800b006ebc74943bbsm550833otp.18.2024.04.19.05.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 05:13:58 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rxn7t-00FN5C-NG; Fri, 19 Apr 2024 09:13:57 -0300 Date: Fri, 19 Apr 2024 09:13:57 -0300 From: Jason Gunthorpe To: Konstantin Taranov Cc: Konstantin Taranov , "sharmaajay@microsoft.com" , Long Li , "leon@kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH rdma-next 2/2] RDMA/mana_ib: Implement get_dma_mr Message-ID: <20240419121357.GB223006@ziepe.ca> References: <1713363659-30156-1-git-send-email-kotaranov@linux.microsoft.com> <1713363659-30156-3-git-send-email-kotaranov@linux.microsoft.com> <20240417145106.GV223006@ziepe.ca> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 19, 2024 at 09:14:14AM +0000, Konstantin Taranov wrote: > > From: Jason Gunthorpe > > On Wed, Apr 17, 2024 at 07:20:59AM -0700, Konstantin Taranov wrote: > > > From: Konstantin Taranov > > > > > > Implement allocation of DMA-mapped memory regions. > > > > > > Signed-off-by: Konstantin Taranov > > > --- > > > drivers/infiniband/hw/mana/device.c | 1 + > > > drivers/infiniband/hw/mana/mr.c | 36 > > +++++++++++++++++++++++++++++ > > > include/net/mana/gdma.h | 5 ++++ > > > 3 files changed, 42 insertions(+) > > > > What is the point of doing this without supporting enough verbs to allow a > > kernel ULP? > > > > True, the proposed code is useless at this state. > Nevertheless, mana_ib team aims to send kernel ULP patches after we are done > with uverbs pathes (i.e., udata is not null). As this change does not conflict with the > current effort, I decided to send this patch now. I can extend the series to make > it more useful. > > Jason, could you suggest a minimal list of ib_device_ops methods, that includes > get_dma_mr, which can be approved? Is there any chance you can send a single series to support a ULP. NVMe or something like? Jason