From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Ira Weiny <ira.weiny@intel.com>, <linux-rdma@vger.kernel.org>,
<linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] mm/gup + IB: allow FOLL_FORCE for gup_fast and use in IB
Date: Sun, 24 Nov 2019 18:07:19 -0800 [thread overview]
Message-ID: <25e8092a-3a5c-b75b-9ee8-940fece25389@nvidia.com> (raw)
In-Reply-To: <20191125003715.516290-1-jhubbard@nvidia.com>
On 11/24/19 4:37 PM, John Hubbard wrote:
> Hi Leon, Jason, Christoph,
>
> Maybe I'm overlooking something, but as I wrote in patch 1, it looks
> like we can simply allow FOLL_FORCE to be passed to gup_fast().
>
> This should fix Leon's reported RDMA failure [1] when using patch 2 by
> itself. (I've compile- and boot-tested these, and also did short LTP
> and fio with direct IO tests, but I don't have an Infiniband runtime
> setup that exercises the umem.c code.)
>
> [1] https://lore.kernel.org/r/20191124100724.GH136476@unreal
>
> John Hubbard (2):
> mm/gup: allow FOLL_FORCE for get_user_pages_fast()
> IB/umem: use get_user_pages_fast() to pin DMA pages
>
> drivers/infiniband/core/umem.c | 17 ++++++-----------
> mm/gup.c | 3 ++-
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
OK, based on Jason's response [1] that it's too late to put this into
5.5, let's withdraw this, and I'll resend when it's time to send out
patches for 5.6.
[1] https://lore.kernel.org/r/20191125005339.GC5634@ziepe.ca
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2019-11-25 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 0:37 [PATCH 0/2] mm/gup + IB: allow FOLL_FORCE for gup_fast and use in IB John Hubbard
2019-11-25 0:37 ` [PATCH 1/2] mm/gup: allow FOLL_FORCE for get_user_pages_fast() John Hubbard
2019-11-25 0:37 ` [PATCH 2/2] IB/umem: use get_user_pages_fast() to pin DMA pages John Hubbard
2019-11-25 2:07 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e8092a-3a5c-b75b-9ee8-940fece25389@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).