From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EC4C35247 for ; Sun, 26 Jan 2020 22:21:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D8C220716 for ; Sun, 26 Jan 2020 22:21:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pensando.io header.i=@pensando.io header.b="jTJEVZTJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726144AbgAZWVE (ORCPT ); Sun, 26 Jan 2020 17:21:04 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:38733 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727479AbgAZWVE (ORCPT ); Sun, 26 Jan 2020 17:21:04 -0500 Received: by mail-pf1-f195.google.com with SMTP id x185so3992120pfc.5 for ; Sun, 26 Jan 2020 14:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=2qobJGOl3MqPUo0qYrlkgJ1xbb0O4O5NLS5Pl3hJ6Vo=; b=jTJEVZTJN5JzjCcn/+aEMT53FdikonofqgsVYj4+hq8ZfN+inHKpuLJgFIpWwJvL+B YEsZoqJF+b23tKyZ+TxMfGanZCsPhy4TQKA4rtf+tzheB60SItIJaQwiTwCL83l1nAHN gyZuJ85/mZWPwlBeDFwpL/nzJ4Blabr5/B3MvR4BBY7FX+m2FhM/ryf1ZNGq2umb5rs/ Fy/4C7GsttdZGh1j1nupa9VxsENjy7q5w3ASCtzMBxSzu5l8z40zAhR9U25v1J+LA/eB 1JSAjzmiFdLR0fAcdz99r3+qZigEqueagIzuG/rHQLIvvTCuiqTz0ir42sxhrfoNR41i Ln2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2qobJGOl3MqPUo0qYrlkgJ1xbb0O4O5NLS5Pl3hJ6Vo=; b=Fz66CV8pXNmxGrP3Pgxyy0yYsOROIc4Q8PAbUgMGDSKC3+xlrs5ixDhAAsVjn+gyr6 OvgN4uYC+MoGGfISIRJnlCkijmOz8HwXpocjWmphVE/MRulQJ6N96ridLHg5iRhPFDnj jVIi6vez6VCy1Ulka0BLlhmAVVpiqQFUhpngAFkKfjxJakHdyUMTgXS7eRMcTHRcFMmD JwX0mD6mUjSQUlqp34ToD0ZK6LKKZZqNuofB3mfQgJJ3oGou40j3eZasb5pQfLSxej1o /tsnZ5N5EQdVmNTIkFtL2uP88FQF6Wxq1kVW0o5173p6+ilEz/MgiATlGt+VFJKNNH9d Vcjw== X-Gm-Message-State: APjAAAUU0xNb/mOj+QH1QDfC4sVFTkKKNqPgJhx54aZJimoYxh6UnRCp a0xAhnIGFXnvnValyx5hFQcmbBqO7QF1zg== X-Google-Smtp-Source: APXvYqwVt2LxgzEZ1Lsk1j8EUmd5N/BVRa7rhbtUJodcmaNr3MYdiDdXPUvBH/r5fwvR2euOvxKZfA== X-Received: by 2002:a62:64d8:: with SMTP id y207mr6594094pfb.208.1580077263076; Sun, 26 Jan 2020 14:21:03 -0800 (PST) Received: from Shannons-MacBook-Pro.local (static-50-53-47-17.bvtn.or.frontiernet.net. [50.53.47.17]) by smtp.gmail.com with ESMTPSA id i2sm13597220pgi.94.2020.01.26.14.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2020 14:21:02 -0800 (PST) Subject: Re: [PATCH net-next] net/core: Replace driver version to be kernel version To: Jakub Kicinski , Leon Romanovsky Cc: "David S . Miller" , Michal Kalderon , linux-netdev , RDMA mailing list References: <20200123130541.30473-1-leon@kernel.org> <43d43a45-18db-f959-7275-63c9976fdf40@pensando.io> <20200126194110.GA3870@unreal> <20200126124957.78a31463@cakuba> <20200126210850.GB3870@unreal> <20200126133353.77f5cb7e@cakuba> From: Shannon Nelson Message-ID: <2a8d0845-9e6d-30ab-03d9-44817a7c2848@pensando.io> Date: Sun, 26 Jan 2020 14:21:58 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200126133353.77f5cb7e@cakuba> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 1/26/20 1:33 PM, Jakub Kicinski wrote >> The long-standing policy in kernel that we don't really care about >> out-of-tree code. > Yeah... we all know it's not that simple :) > > The in-tree driver versions are meaningless and cause annoying churn > when people arbitrarily bump them. If we can get people to stop doing > that we'll be happy, that's all there is to it. > Perhaps it would be helpful if this standard was applied to all the drivers equally?  For example, I see that this week's ice driver update from Intel was accepted with no comment on their driver version bump. Look, if we want to stamp all in-kernel drivers with the kernel version, fine.  But let's do it in a way that doesn't break the out-of-tree driver ability to report something else.  Can we set up a macro for in-kernel drivers to use in their get_drvinfo callback and require drivers to use that macro?  Then the out-of-tree drivers are able to replace that macro with whatever they need.  Just don't forcibly bash the value from higher up in the stack. sln