From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A83AC433E0 for ; Wed, 13 May 2020 18:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA969205CB for ; Wed, 13 May 2020 18:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390258AbgEMSpq (ORCPT ); Wed, 13 May 2020 14:45:46 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38905 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390103AbgEMSpn (ORCPT ); Wed, 13 May 2020 14:45:43 -0400 Received: by mail-pg1-f193.google.com with SMTP id u5so141840pgn.5; Wed, 13 May 2020 11:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oGExS5qpyhaJE9sRdyvo65rhkDZrEjTLCCqtKDwIC/k=; b=TS/6HqhyaUBitGN4hJlVvmHSFhkuo70+216kyjBQDE1WZjef3NGT/YuohVXnCKZr7z K4PJgBtP1wkjYZNeHCOUTKvZeggbMRYrUPv0kGtbOUxxXjB0868SRXo5nj2JebjktftL IvFmHQJqsyhNa8c5iPBpd2+wzW660tNQcojBVoZiRfU5OQi/BBL8H9pan2p7VymaHAko wN1u32p6TWkDOYso15HTxqJL2328FnrUWVcyLCaXGnAsP+fN/vTBcapBq/2ZVUH2B6AY +NlLPGmghXU30Cq1kmHJcpUU1RbuVGxR1r3omjcrYaogMV8KW2lJad5a5hzsFuqNzKKL X/SQ== X-Gm-Message-State: AOAM5338Ixu2NVbtVMVyhA5hkSRag2/BM++OtuHK2zdZiRvOSVvkWnr8 Mmya9dyMxMYZK56jbGtBOn4= X-Google-Smtp-Source: ABdhPJxuCtZ6LqG/D7UsLLlMEE3Gj8Q00WqSwzmkuBnzsqf4vGt4xYIyJ/k3v57Ipr7A3TPHVfXEFQ== X-Received: by 2002:a62:7d91:: with SMTP id y139mr631244pfc.172.1589395542971; Wed, 13 May 2020 11:45:42 -0700 (PDT) Received: from ?IPv6:2601:647:4802:9070:59e0:deac:a73c:5d11? ([2601:647:4802:9070:59e0:deac:a73c:5d11]) by smtp.gmail.com with ESMTPSA id g10sm238580pfk.103.2020.05.13.11.45.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 11:45:41 -0700 (PDT) Subject: Re: remove kernel_setsockopt and kernel_getsockopt To: Christoph Hellwig , "David S. Miller" , Jakub Kicinski Cc: Marcelo Ricardo Leitner , Eric Dumazet , linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , linux-kernel@vger.kernel.org, Jon Maloy , Ying Xue , ocfs2-devel@oss.oracle.com References: <20200513062649.2100053-1-hch@lst.de> From: Sagi Grimberg Message-ID: <2c9a28f7-4268-2295-0d64-ada9178a5553@grimberg.me> Date: Wed, 13 May 2020 11:45:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200513062649.2100053-1-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org > Hi Dave, > > this series removes the kernel_setsockopt and kernel_getsockopt > functions, and instead switches their users to small functions that > implement setting (or in one case getting) a sockopt directly using > a normal kernel function call with type safety and all the other > benefits of not having a function call. > > In some cases these functions seem pretty heavy handed as they do > a lock_sock even for just setting a single variable, but this mirrors > the real setsockopt implementation - counter to that a few kernel > drivers just set the fields directly already. > > Nevertheless the diffstat looks quite promising: > > 42 files changed, 721 insertions(+), 799 deletions(-) For the nvme-tcp bits, Acked-by: Sagi Grimberg