From: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
To: Christoph Hellwig <hch@infradead.org>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"jglisse@redhat.com" <jglisse@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"yishaih@nvidia.com" <yishaih@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled
Date: Mon, 30 Aug 2021 09:30:42 +0000 [thread overview]
Message-ID: <2d30c629-5169-1405-4f3e-03d630a99678@fujitsu.com> (raw)
In-Reply-To: <YSyJdUirSGv01nTy@infradead.org>
On 30/08/2021 15:32, Christoph Hellwig wrote:
> On Sat, Aug 28, 2021 at 09:04:41AM +0800, Li Zhijian wrote:
>> + if (!pte_devmap(pte) && pte_special(pte) &&
>> + !is_zero_pfn(pte_pfn(pte))) {
> Maybe this is a little too superficial and nitpicky, but I find the
> ordering of the checks a little strange. Why not do the pte_special
> first and then the exlusions from it later?
>
It sounds good to me, let's update it
Thanks
Zhijian
prev parent reply other threads:[~2021-08-30 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 1:04 [PATCH v2] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled Li Zhijian
2021-08-30 7:32 ` Christoph Hellwig
2021-08-30 9:30 ` lizhijian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d30c629-5169-1405-4f3e-03d630a99678@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).