From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leonro@mellanox.com>,
Jason Gunthorpe <jgg@mellanox.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>,
Ariel Levkovich <lariel@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>
Subject: Re: [PATCH rdma-rc 2/2] IB/mlx5: Fix device memory flows
Date: Thu, 12 Dec 2019 17:00:49 -0500 [thread overview]
Message-ID: <2e16247d69f4c2ab924b67ae85757184f6bcc741.camel@redhat.com> (raw)
In-Reply-To: <20191212112144.GW67461@unreal>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Thu, 2019-12-12 at 11:21 +0000, Leon Romanovsky wrote:
> > > @@ -2288,8 +2332,9 @@ static int handle_alloc_dm_memic(struct
> > > ib_ucontext *ctx,
> > > {
> > > struct mlx5_dm *dm_db = &to_mdev(ctx->device)->dm;
> > > u64 start_offset;
> > > - u32 page_idx;
> > > + u16 page_idx = 0;
> >
> > This hunk is not needed.
>
> To be clear, I wanted to say this about "= 0" part. The change of the
> type is still needed.
>
> Thanks
I fixed it up when I took the two patches. Applied to for-rc, thanks.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-12 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 10:02 [PATCH rdma-rc 0/2] Prevent device memory VA reuse Leon Romanovsky
2019-12-12 10:02 ` [PATCH rdma-rc 1/2] IB/core: Introduce rdma_user_mmap_entry_insert_range() API Leon Romanovsky
2019-12-12 10:02 ` [PATCH rdma-rc 2/2] IB/mlx5: Fix device memory flows Leon Romanovsky
2019-12-12 11:15 ` Leon Romanovsky
2019-12-12 11:21 ` Leon Romanovsky
2019-12-12 22:00 ` Doug Ledford [this message]
2019-12-15 18:55 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e16247d69f4c2ab924b67ae85757184f6bcc741.camel@redhat.com \
--to=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=lariel@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).