From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1159DC2D0FD for ; Wed, 13 May 2020 13:17:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC52F20675 for ; Wed, 13 May 2020 13:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G6XxcD+D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387480AbgEMNR4 (ORCPT ); Wed, 13 May 2020 09:17:56 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23561 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387545AbgEMNRz (ORCPT ); Wed, 13 May 2020 09:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589375874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uvCkRI/K32PIBqaQ7LcOfghe4diMRxEm5e5JsVQlwss=; b=G6XxcD+DnVzbRBzroKEJYY/6ep+zurnrvHBQE/oit7bPj5Hcs3KiMHQVABrUrCMTXm9Qmt et43YntAv2FAuB6+lYjFvEdlDp8b+oi/Vb7d26H5JI7jlF2IlS31YdBLLx6jCieWahoCwq +BzgMpiPErcgpiE/glAOGvoXYKjgz0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-9T7X1SL4M7u16KqBfljjIQ-1; Wed, 13 May 2020 09:17:52 -0400 X-MC-Unique: 9T7X1SL4M7u16KqBfljjIQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53C148014C0; Wed, 13 May 2020 13:17:49 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-59.rdu2.redhat.com [10.10.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8A53610F2; Wed, 13 May 2020 13:17:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200513062649.2100053-22-hch@lst.de> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, "David S. Miller" , Jakub Kicinski , Marcelo Ricardo Leitner , Eric Dumazet , linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , linux-kernel@vger.kernel.org, Jon Maloy , Ying Xue , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3123897.1589375861.1@warthog.procyon.org.uk> Date: Wed, 13 May 2020 14:17:41 +0100 Message-ID: <3123898.1589375861@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits]