From: Divya Indi <divya.indi@oracle.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Leon Romanovsky" <leon@kernel.org>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
"Kaike Wan" <kaike.wan@intel.com>,
"Gerd Rausch" <gerd.rausch@oracle.com>,
"Håkon Bugge" <haakon.bugge@oracle.com>,
"Srinivas Eeda" <srinivas.eeda@oracle.com>,
"Rama Nichanamatlu" <rama.nichanamatlu@oracle.com>,
"Doug Ledford" <dledford@redhat.com>
Subject: Re: [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg
Date: Fri, 19 Jun 2020 17:43:14 -0700 [thread overview]
Message-ID: <3770b85e-c684-f534-d6d5-84cf0874e485@oracle.com> (raw)
In-Reply-To: <20200617182410.GK6578@ziepe.ca>
Hi Jason,
Thanks for taking the time to review!
On 6/17/20 11:24 AM, Jason Gunthorpe wrote:
> On Tue, Jun 16, 2020 at 10:56:53AM -0700, Divya Indi wrote:
>> The other option might be to use GFP_NOWAIT conditionally ie
>> (only use GFP_NOWAIT when GFP_ATOMIC is not specified in gfp_mask else
>> use GFP_ATOMIC). Eventual goal being to not have a blocking memory allocation.
> This is probably safest for now, unless you can audit all callers and
> see if they can switch to GFP_NOWAIT as well
At present the callers with GFP_ATOMIC appear to be ipoib. Might not be
feasible to change them all to GFP_NOWAIT.
Will incorporate the review comments and send out v3 early next week.
Thanks,
Divya
>
> Jason
next prev parent reply other threads:[~2020-06-20 0:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 14:46 Review Request Divya Indi
2020-06-08 14:46 ` [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg Divya Indi
2020-06-09 7:00 ` Leon Romanovsky
2020-06-09 14:45 ` Divya Indi
2020-06-14 6:41 ` Leon Romanovsky
2020-06-16 17:56 ` Divya Indi
2020-06-17 5:17 ` Leon Romanovsky
2020-06-17 18:23 ` Jason Gunthorpe
2020-06-21 7:12 ` Leon Romanovsky
2020-06-17 18:24 ` Jason Gunthorpe
2020-06-20 0:43 ` Divya Indi [this message]
2020-06-09 7:03 ` Review Request Leon Romanovsky
2020-06-09 15:44 ` Divya Indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3770b85e-c684-f534-d6d5-84cf0874e485@oracle.com \
--to=divya.indi@oracle.com \
--cc=dledford@redhat.com \
--cc=gerd.rausch@oracle.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=kaike.wan@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rama.nichanamatlu@oracle.com \
--cc=srinivas.eeda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).