From: Mark Bloch <markb@mellanox.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] iwcm: don't hold the irq disabled lock on iw_rem_ref
Date: Tue, 3 Sep 2019 19:33:08 +0000 [thread overview]
Message-ID: <3859b00b-9963-32c5-b6ed-8433fc4ec409@mellanox.com> (raw)
In-Reply-To: <20190903192223.17342-1-sagi@grimberg.me>
On 9/3/19 12:22 PM, Sagi Grimberg wrote:
> This may be the final put on a qp and result in freeing
> resourcesand should not be done with interrupts disabled.
>
> Produce the following warning:
> --
> [ 317.026048] WARNING: CPU: 1 PID: 443 at kernel/smp.c:425 smp_call_function_many+0xa0/0x260
> [ 317.026131] Call Trace:
> [ 317.026159] ? load_new_mm_cr3+0xe0/0xe0
> [ 317.026161] on_each_cpu+0x28/0x50
> [ 317.026183] __purge_vmap_area_lazy+0x72/0x150
> [ 317.026200] free_vmap_area_noflush+0x7a/0x90
> [ 317.026202] remove_vm_area+0x6f/0x80
> [ 317.026203] __vunmap+0x71/0x210
> [ 317.026211] siw_free_qp+0x8d/0x130 [siw]
> [ 317.026217] destroy_cm_id+0xc3/0x200 [iw_cm]
> [ 317.026222] rdma_destroy_id+0x224/0x2b0 [rdma_cm]
> [ 317.026226] nvme_rdma_reset_ctrl_work+0x2c/0x70 [nvme_rdma]
> [ 317.026235] process_one_work+0x1f4/0x3e0
> [ 317.026249] worker_thread+0x221/0x3e0
> [ 317.026252] ? process_one_work+0x3e0/0x3e0
> [ 317.026256] kthread+0x117/0x130
> [ 317.026264] ? kthread_create_worker_on_cpu+0x70/0x70
> [ 317.026275] ret_from_fork+0x35/0x40
> --
>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/infiniband/core/iwcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c
> index 72141c5b7c95..94566271dbff 100644
> --- a/drivers/infiniband/core/iwcm.c
> +++ b/drivers/infiniband/core/iwcm.c
> @@ -427,7 +427,9 @@ static void destroy_cm_id(struct iw_cm_id *cm_id)
> break;
> }
> if (cm_id_priv->qp) {
> + spin_unlock_irqrestore(&cm_id_priv->lock, flags);
> cm_id_priv->id.device->ops.iw_rem_ref(cm_id_priv->qp);
> + spin_lock_irqsave(&cm_id_priv->lock, flags);
> cm_id_priv->qp = NULL;
Shouldn't you first do cm_id_priv->qp = NULL and only then
unlock and destroy the qp?
Mark
> }
> spin_unlock_irqrestore(&cm_id_priv->lock, flags);
>
next prev parent reply other threads:[~2019-09-03 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 19:22 [PATCH] iwcm: don't hold the irq disabled lock on iw_rem_ref Sagi Grimberg
2019-09-03 19:33 ` Mark Bloch [this message]
2019-09-04 1:07 ` Sagi Grimberg
2019-09-04 6:03 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3859b00b-9963-32c5-b6ed-8433fc4ec409@mellanox.com \
--to=markb@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).