From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
"Daniel Kranzdorf" <dkkranzd@amazon.com>,
Firas JahJah <firasj@amazon.com>
Subject: Re: [PATCH for-rc] RDMA/efa: Clear the admin command buffer prior to its submission
Date: Thu, 14 Nov 2019 18:17:05 +0200 [thread overview]
Message-ID: <3abc3f93-aa71-cc0e-17dd-7bfed8625eca@amazon.com> (raw)
In-Reply-To: <20191114155913.GA11028@ziepe.ca>
On 14/11/2019 17:59, Jason Gunthorpe wrote:
> On Tue, Nov 12, 2019 at 11:26:08AM +0200, Gal Pressman wrote:
>> We cannot rely on the entry memcpy as we only copy the actual size of
>> the command, the rest of the bytes must be memset to zero.
>>
>> Fixes: 0420e542569b ("RDMA/efa: Implement functions that submit and complete admin commands")
>> Reviewed-by: Daniel Kranzdorf <dkkranzd@amazon.com>
>> Reviewed-by: Firas JahJah <firasj@amazon.com>
>> Signed-off-by: Gal Pressman <galpress@amazon.com>
>> ---
>> drivers/infiniband/hw/efa/efa_com.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> This isn't really -rc material since the device will have to be
> compatible with these old kernels for quite some time.
That's why I pushed it to -rc, this bug fix must be applied to these kernels
(5.2, 5.3) as well through stable.
If we're trying to avoid pushing this change late in the -rc cycle, I'm fine
with this patch going through -next and backported to 5.4 stable as well.
prev parent reply other threads:[~2019-11-14 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:26 [PATCH for-rc] RDMA/efa: Clear the admin command buffer prior to its submission Gal Pressman
2019-11-13 0:17 ` Jason Gunthorpe
2019-11-13 13:55 ` Gal Pressman
2019-11-14 15:59 ` Jason Gunthorpe
2019-11-14 16:17 ` Gal Pressman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3abc3f93-aa71-cc0e-17dd-7bfed8625eca@amazon.com \
--to=galpress@amazon.com \
--cc=dkkranzd@amazon.com \
--cc=dledford@redhat.com \
--cc=firasj@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).