From: Max Gurtovoy <maxg@mellanox.com>
To: Leon Romanovsky <leon@kernel.org>, Christoph Hellwig <hch@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
Yamin Friedman <yaminf@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH rdma-next 3/3] RDMA/rw: Support threshold for registration vs scattering to local pages
Date: Mon, 7 Oct 2019 13:07:02 +0300 [thread overview]
Message-ID: <3b0f2757-eb84-f5f8-d036-4bdce21ae943@mellanox.com> (raw)
In-Reply-To: <20191007075437.GV5855@unreal>
On 10/7/2019 10:54 AM, Leon Romanovsky wrote:
> On Sun, Oct 06, 2019 at 11:58:25PM -0700, Christoph Hellwig wrote:
>>> /*
>>> - * Check if the device might use memory registration. This is currently only
>>> - * true for iWarp devices. In the future we can hopefully fine tune this based
>>> - * on HCA driver input.
>>> + * Check if the device might use memory registration.
>>> */
>> Please keep the important bits of this comments instead of just
>> removing them.
>>
>>> {
>>> @@ -30,6 +28,8 @@ static inline bool rdma_rw_can_use_mr(struct ib_device *dev, u8 port_num)
>>> return true;
>>> if (unlikely(rdma_rw_force_mr))
>>> return true;
>>> + if (dev->attrs.max_sgl_rd)
>>> + return true;
>> Logically this should go before the rdma_rw_force_mr check.
>>
>>> if (unlikely(rdma_rw_force_mr))
>>> return true;
>>> + if (dev->attrs.max_sgl_rd && dir == DMA_FROM_DEVICE
>>> + && dma_nents > dev->attrs.max_sgl_rd)
>> Wrong indendation. The && belongs on the first line. And again, this
>> logically belongs before the rdma_rw_force_mr check.
> I'll fix.
>
> Thanks
The above comments looks reasonable.
Nice optimization Yamin.
prev parent reply other threads:[~2019-10-07 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 15:59 [PATCH rdma-next 0/3] Optimize SGL registration Leon Romanovsky
2019-10-06 15:59 ` [PATCH mlx5-next 1/3] net/mlx5: Expose optimal performance scatter entries capability Leon Romanovsky
2019-10-06 15:59 ` [PATCH rdma-next 2/3] RDMA/mlx5: Add capability for max sge to get optimized performance Leon Romanovsky
2019-10-07 7:13 ` Christoph Hellwig
2019-10-07 7:54 ` Leon Romanovsky
2019-10-06 15:59 ` [PATCH rdma-next 3/3] RDMA/rw: Support threshold for registration vs scattering to local pages Leon Romanovsky
2019-10-07 6:58 ` Christoph Hellwig
2019-10-07 7:54 ` Leon Romanovsky
2019-10-07 10:07 ` Max Gurtovoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0f2757-eb84-f5f8-d036-4bdce21ae943@mellanox.com \
--to=maxg@mellanox.com \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=yaminf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).