From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: "Pearson, Robert B" <robert.pearson2@hpe.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Jinpu Wang <jinpu.wang@ionos.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Bob Pearson <rpearsonhpe@gmail.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: bug report for rxe
Date: Wed, 23 Feb 2022 12:43:08 +0800 [thread overview]
Message-ID: <3b6ddb23-6dfa-29e2-27fd-741c1e3e576d@linux.dev> (raw)
In-Reply-To: <PH7PR84MB1488DB95EFB4F86FCDC7B8E6BC3B9@PH7PR84MB1488.NAMPRD84.PROD.OUTLOOK.COM>
On 2/23/22 12:58 AM, Pearson, Robert B wrote:
>> After investigation, seems the culprit is commit 647bf13ce944 ("RDMA/rxe:
>> Create duplicate mapping tables for FMRs"). The problem is
>> mr_check_range returns -EFAULT after find iova and length are not
>> valid, so connection between two VMs can't be established.
>>
>> Revert the commit manually or apply below temporary change, rxe works
>> again with rnbd/rtrs though I don't think it is the right thing to do.
>> Could experts provide a proper solution? Thanks.
>>
> This patch fixed failures in blktests and srp which were discussed at length. See e.g.
>
> https://lore.kernel.org/linux-rdma/20210907163939.GW1200268@ziepe.ca/
Thanks for the link, which reminds me the always_invalidate parameter in
rtrs_server.
> and related messages. The conclusion was that two mappings were required. One owned by the
> driver and one by the 'hardware', i.e. bottom half in the rxe case, allowing updating a new mapping
> while the old one is still active and then switching them.
>
> If this case has iova and length not valid as indicated is there a problem with the test case?
And after disable always_invalidate (which is enabled by default),
rnbd/rtrs over roce
works either. So I suppose there might be potential issue for
always_invalidate=Y in
rtrs server side since invalidate works for srp IIUC, @Jinpu.
Thanks,
Guoqing
next prev parent reply other threads:[~2022-02-23 4:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 7:36 [PATCH 0/3] patches and bug report for rxe Guoqing Jiang
2022-02-10 7:36 ` [PATCH 1/3] RDMA/rxe: Replace write_lock_bh with write_lock_irqsave in __rxe_add_index Guoqing Jiang
2022-02-10 13:29 ` Zhu Yanjun
2022-02-10 7:36 ` [PATCH 2/3] RDMA/rxe: Replace write_lock_bh with write_lock_irqsave in __rxe_drop_index Guoqing Jiang
2022-02-10 14:16 ` Zhu Yanjun
2022-02-10 15:49 ` Bob Pearson
2022-02-11 10:09 ` Guoqing Jiang
2022-02-11 17:37 ` Bob Pearson
2022-02-12 0:59 ` Guoqing Jiang
2022-02-10 7:36 ` [PATCH 3/3] RDMA/rxe: Replace spin_lock_bh with spin_lock_irqsave in post_one_send Guoqing Jiang
2022-02-10 14:18 ` Zhu Yanjun
2022-02-22 9:50 ` bug report for rxe Guoqing Jiang
2022-02-22 10:04 ` Zhu Yanjun
2022-02-22 16:58 ` Pearson, Robert B
2022-02-23 4:43 ` Guoqing Jiang [this message]
2022-02-23 5:01 ` Bob Pearson
2022-02-23 5:50 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b6ddb23-6dfa-29e2-27fd-741c1e3e576d@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@ionos.com \
--cc=linux-rdma@vger.kernel.org \
--cc=robert.pearson2@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).