From: Bart Van Assche <bvanassche@acm.org>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org,
Laurence Oberman <loberman@redhat.com>,
Kamal Heib <kamalheib1@gmail.com>
Subject: Re: [PATCH 1/4] RDMA/srp: Make the channel count configurable per target
Date: Sat, 23 May 2020 08:22:19 -0700 [thread overview]
Message-ID: <3fc10293-d65b-fee3-ad5c-833323516e96@acm.org> (raw)
In-Reply-To: <20200523135523.GA569407@unreal>
On 2020-05-23 06:55, Leon Romanovsky wrote:
> On Fri, May 22, 2020 at 02:33:38PM -0700, Bart Van Assche wrote:
>> Increase the flexibility of the SRP initiator driver by making the channel
>> count configurable per target instead of only providing a kernel module
>> parameter for configuring the channel count.
>>
>> Cc: Laurence Oberman <loberman@redhat.com>
>> Cc: Kamal Heib <kamalheib1@gmail.com>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>> drivers/infiniband/ulp/srp/ib_srp.c | 21 ++++++++++++++++-----
>> 1 file changed, 16 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
>> index 00b4f88b113e..d686c39710c0 100644
>> --- a/drivers/infiniband/ulp/srp/ib_srp.c
>> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
>> @@ -3424,6 +3424,7 @@ enum {
>> SRP_OPT_IP_DEST = 1 << 16,
>> SRP_OPT_TARGET_CAN_QUEUE= 1 << 17,
>> SRP_OPT_MAX_IT_IU_SIZE = 1 << 18,
>> + SRP_OPT_CH_COUNT = 1 << 19,
>> };
>>
>> static unsigned int srp_opt_mandatory[] = {
>> @@ -3457,6 +3458,7 @@ static const match_table_t srp_opt_tokens = {
>> { SRP_OPT_IP_SRC, "src=%s" },
>> { SRP_OPT_IP_DEST, "dest=%s" },
>> { SRP_OPT_MAX_IT_IU_SIZE, "max_it_iu_size=%d" },
>> + { SRP_OPT_CH_COUNT, "ch_count=%d", },
>
> Why did you use %d and not %u?
Hi Leon,
There is more kernel code that uses %d for unsigned integers. Anyway, if
someone cares enough I can change %d into %u.
Bart.
next prev parent reply other threads:[~2020-05-23 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 21:33 [PATCH 0/4] SRP initiator and target patches for kernel v5.8 Bart Van Assche
2020-05-22 21:33 ` [PATCH 1/4] RDMA/srp: Make the channel count configurable per target Bart Van Assche
2020-05-23 13:55 ` Leon Romanovsky
2020-05-23 15:22 ` Bart Van Assche [this message]
2020-05-24 6:20 ` Leon Romanovsky
2020-05-22 21:33 ` [PATCH 2/4] RDMA/srpt: Make debug output more detailed Bart Van Assche
2020-05-22 21:33 ` [PATCH 3/4] RDMA/srpt: Reduce max_recv_sge to 1 Bart Van Assche
2020-05-22 21:33 ` [PATCH 4/4] RDMA/srpt: Increase max_send_sge Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc10293-d65b-fee3-ad5c-833323516e96@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).