From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Leon Romanovsky <leonro@nvidia.com>
Cc: Avihai Horon <avihaih@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>, <linux-rdma@vger.kernel.org>,
"Leybovich, Yossi" <sleybo@amazon.com>
Subject: Re: New GID query API broke EFA
Date: Thu, 22 Oct 2020 15:12:36 +0300 [thread overview]
Message-ID: <460e8221-6837-0428-7401-52d2ef5d8a4c@amazon.com> (raw)
In-Reply-To: <20201022121035.GX6219@nvidia.com>
On 22/10/2020 15:10, Jason Gunthorpe wrote:
> On Thu, Oct 22, 2020 at 02:21:00PM +0300, Leon Romanovsky wrote:
>> On Thu, Oct 22, 2020 at 01:58:29PM +0300, Gal Pressman wrote:
>>> Hi all,
>>>
>>> The new IOCTL query GID API 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query
>>> API to user space") currently breaks EFA, as ibv_query_gid() no longer works.
>>>
>>> The problem is that the IOCTL call checks for:
>>> if (!rdma_ib_or_roce(ib_dev, port_num))
>>> return -EOPNOTSUPP;
>>>
>>> EFA is neither of these, but it uses GIDs.
>>>
>>> Any objections to remove the check? Any other solutions come to mind?
>>
>> We added this check to protect access to rdma_get_gid_attr() for devices
>> without GID table.
>> 1234 table = rdma_gid_table(device, port_num);
>> 1235 if (index < 0 || index >= table->sz)
>> 1236 return ERR_PTR(-EINVAL);
>>
>> So you can extend that function to return for table == NULL an error and
>> remove rdma_ib_or_roce()
>
> How does table == NULL ever?
A driver with gid_tbl_len == 0 would make the allocation return NULL, no?
next prev parent reply other threads:[~2020-10-22 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 10:58 New GID query API broke EFA Gal Pressman
2020-10-22 11:21 ` Leon Romanovsky
2020-10-22 11:49 ` Gal Pressman
2020-10-22 12:10 ` Jason Gunthorpe
2020-10-22 12:12 ` Gal Pressman [this message]
2020-10-22 12:15 ` Gal Pressman
2020-10-22 12:23 ` Leon Romanovsky
2020-10-22 12:23 ` Leon Romanovsky
2020-10-22 16:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460e8221-6837-0428-7401-52d2ef5d8a4c@amazon.com \
--to=galpress@amazon.com \
--cc=avihaih@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).