Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Haakon Bugge <haakon.bugge@oracle.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH RESEND][next] rds: Fix fall-through warnings for Clang
Date: Mon, 17 May 2021 20:01:48 -0500
Message-ID: <480ab028-5de9-85ea-3dc1-275eba61f544@embeddedor.com> (raw)
In-Reply-To: <6AB78D3D-C73D-4633-A6FD-9452DD8E4751@oracle.com>

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 5/6/21 01:50, Haakon Bugge wrote:
> Sorry for the delay.
> 
> 
>> On 20 Apr 2021, at 22:10, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>
>> Hi all,
>>
>> Friendly ping: who can take this, please?
>>
>> Thanks
>> --
>> Gustavo
>>
>> On 3/5/21 03:06, Gustavo A. R. Silva wrote:
>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
>>> warnings by explicitly adding multiple break statements instead of
>>> letting the code fall through to the next case.
>>>
>>> Link: https://github.com/KSPP/linux/issues/115
>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> 
> 
> Thxs, Håkon
> 
> 
>>> ---
>>> net/rds/tcp_connect.c | 1 +
>>> net/rds/threads.c     | 2 ++
>>> 2 files changed, 3 insertions(+)
>>>
>>> diff --git a/net/rds/tcp_connect.c b/net/rds/tcp_connect.c
>>> index 4e64598176b0..5461d77fff4f 100644
>>> --- a/net/rds/tcp_connect.c
>>> +++ b/net/rds/tcp_connect.c
>>> @@ -78,6 +78,7 @@ void rds_tcp_state_change(struct sock *sk)
>>> 	case TCP_CLOSE_WAIT:
>>> 	case TCP_CLOSE:
>>> 		rds_conn_path_drop(cp, false);
>>> +		break;
>>> 	default:
>>> 		break;
>>> 	}
>>> diff --git a/net/rds/threads.c b/net/rds/threads.c
>>> index 32dc50f0a303..1f424cbfcbb4 100644
>>> --- a/net/rds/threads.c
>>> +++ b/net/rds/threads.c
>>> @@ -208,6 +208,7 @@ void rds_send_worker(struct work_struct *work)
>>> 		case -ENOMEM:
>>> 			rds_stats_inc(s_send_delayed_retry);
>>> 			queue_delayed_work(rds_wq, &cp->cp_send_w, 2);
>>> +			break;
>>> 		default:
>>> 			break;
>>> 		}
>>> @@ -232,6 +233,7 @@ void rds_recv_worker(struct work_struct *work)
>>> 		case -ENOMEM:
>>> 			rds_stats_inc(s_recv_delayed_retry);
>>> 			queue_delayed_work(rds_wq, &cp->cp_recv_w, 2);
>>> +			break;
>>> 		default:
>>> 			break;
>>> 		}
>>>
> 

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:06 Gustavo A. R. Silva
2021-04-20 20:10 ` Gustavo A. R. Silva
2021-05-06  6:50   ` Haakon Bugge
2021-05-18  1:01     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480ab028-5de9-85ea-3dc1-275eba61f544@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=gustavoars@kernel.org \
    --cc=haakon.bugge@oracle.com \
    --cc=kuba@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git