From: Rao Shoaib <rao.shoaib@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
somasundaram.krishnasamy@oracle.com
Subject: Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set
Date: Mon, 1 Jun 2020 09:59:30 -0700 [thread overview]
Message-ID: <4f86d778-1f6b-d533-c062-c78daa257829@oracle.com> (raw)
In-Reply-To: <20200529.164107.1817677145426311890.davem@davemloft.net>
On 5/29/20 4:41 PM, David Miller wrote:
> From: rao.shoaib@oracle.com
> Date: Wed, 27 May 2020 01:17:42 -0700
>
>> diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
>> index cba368e55863..7273c681e6c1 100644
>> --- a/include/uapi/linux/rds.h
>> +++ b/include/uapi/linux/rds.h
>> @@ -64,7 +64,7 @@
>>
>> /* supported values for SO_RDS_TRANSPORT */
>> #define RDS_TRANS_IB 0
>> -#define RDS_TRANS_IWARP 1
>> +#define RDS_TRANS_GAP 1
>> #define RDS_TRANS_TCP 2
>> #define RDS_TRANS_COUNT 3
>> #define RDS_TRANS_NONE (~0)
> You can't break user facing UAPI like this, sorry.
I was hoping that this could be considered an exception as IWARP has
been deprecated for almost a decade and there is no current product
using it. With the change any old binary will continue to work, a new
compilation fill fail so that the code can be examined, otherwise we
will never be able to reuse this number.
If the above is not acceptable I can revert this part of the change.
Shoaib
next prev parent reply other threads:[~2020-06-01 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:17 [PATCH net-next] rds: transport module should be auto loaded when transport is set rao.shoaib
2020-05-29 23:41 ` David Miller
2020-06-01 16:59 ` Rao Shoaib [this message]
2020-06-02 6:17 ` Leon Romanovsky
2020-06-02 18:19 ` Rao Shoaib
2020-05-31 10:08 ` Leon Romanovsky
2020-06-01 17:08 ` Rao Shoaib
2020-06-02 6:18 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f86d778-1f6b-d533-c062-c78daa257829@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=somasundaram.krishnasamy@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).