From: Chuck Lever <chuck.lever@oracle.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH v5] IB/core: Trace points for diagnosing completion queue issues
Date: Fri, 8 Nov 2019 09:41:27 -0500 [thread overview]
Message-ID: <533870DD-41E0-41F9-8553-5E84DBDE4EC2@oracle.com> (raw)
In-Reply-To: <20191108142157.GB10956@ziepe.ca>
> On Nov 8, 2019, at 9:21 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Thu, Nov 07, 2019 at 03:54:34PM -0500, Chuck Lever wrote:
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> Reviewed-by: Parav Pandit <parav@mellanox.com>
>> drivers/infiniband/core/Makefile | 2
>> drivers/infiniband/core/cq.c | 36 +++++
>> drivers/infiniband/core/trace.c | 14 ++
>> include/rdma/ib_verbs.h | 11 +-
>> include/trace/events/rdma_core.h | 251 ++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 307 insertions(+), 7 deletions(-)
>> create mode 100644 drivers/infiniband/core/trace.c
>> create mode 100644 include/trace/events/rdma_core.h
>>
>> Changes since v4:
>> - Removed __ib_poll_cq, uninlined ib_poll_cq
>
> Oh I don't think uninlining is such a good idea, isn't this rather
> performance sensitive?
So would you rather go with v4?
Not clear to me that the compiler won't do the right thing,
at least for __ib_process_cq.
--
Chuck Lever
prev parent reply other threads:[~2019-11-08 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 20:54 [PATCH v5] IB/core: Trace points for diagnosing completion queue issues Chuck Lever
2019-11-08 14:21 ` Jason Gunthorpe
2019-11-08 14:41 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533870DD-41E0-41F9-8553-5E84DBDE4EC2@oracle.com \
--to=chuck.lever@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).