From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1788C433ED for ; Thu, 22 Apr 2021 20:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B34AC613DC for ; Thu, 22 Apr 2021 20:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239433AbhDVUak (ORCPT ); Thu, 22 Apr 2021 16:30:40 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:45859 "EHLO mail-pg1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239298AbhDVUaj (ORCPT ); Thu, 22 Apr 2021 16:30:39 -0400 Received: by mail-pg1-f179.google.com with SMTP id d10so33648888pgf.12; Thu, 22 Apr 2021 13:30:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ErwniLcaGVO/kxmEwl8gGV0QjSUQKJ/t9ZJlSqCEkEo=; b=UHgXJpPoOZl081FZ+7kXYg7dS6ENxhs/XxcdbvKZCeDIyYkcYigb8pTmVeDOynj2dU yAqCRdte7xpQJkrcwylxj+YmeQ7bN/6xVlrBMUYEIVvQUGDtq77EDoRnpGC5g0O/94Lq /z9zQfTWs9jeBCu6WkSWswffr6lBeCI+hr66LumWxgIQjjXwxhAYWK3zs0BS1vdI7GGg iAsAkEA4MX+v67TFaGljp+vebE9hu/GIJpOqn+1z2ltMsCKIbmxHZHTDhJLjeSE/Q/L4 Hv+q2g19vtZGhhrTfq2h0Eoh6DIzLf46TumoHK/mIi/GqhoCwu/FeC5buUcuLRE/N5LU aPew== X-Gm-Message-State: AOAM531AAsbQr95dMFhLh+N+Ltd2fZeZQNcWNxzNvMzhi/z+mNP/a8fC E6wY4WUMsX09fplieFsVjPRbAXnXkLw6MA== X-Google-Smtp-Source: ABdhPJxNNltJlaq4UgjTTlU6u2x4QZW/U/kixD1KrCTqqMjziRQo0Aws14ZZK/60vBVE/YGzE7v9Mg== X-Received: by 2002:a63:e00f:: with SMTP id e15mr407170pgh.317.1619123403370; Thu, 22 Apr 2021 13:30:03 -0700 (PDT) Received: from [192.168.51.110] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id k21sm2751759pfi.28.2021.04.22.13.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 13:30:02 -0700 (PDT) Subject: Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier To: Leon Romanovsky Cc: Jason Gunthorpe , Marion et Christophe JAILLET , tj@kernel.org, jiangshanlai@gmail.com, saeedm@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <042f5fff-5faf-f3c5-0819-b8c8d766ede6@acm.org> <1032428026.331.1618814178946.JavaMail.www@wwinf2229> <40c21bfe-e304-230d-b319-b98063347b8b@acm.org> <20210422122419.GF2047089@ziepe.ca> <782e329a-7c3f-a0da-5d2f-89871b0c4b9b@acm.org> From: Bart Van Assche Message-ID: <53b2ef14-1b8a-43b1-ef53-e314e2649ea0@acm.org> Date: Thu, 22 Apr 2021 13:30:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 4/22/21 11:00 AM, Leon Romanovsky wrote: > On Thu, Apr 22, 2021 at 10:12:33AM -0700, Bart Van Assche wrote: >> On 4/22/21 5:24 AM, Jason Gunthorpe wrote: >>> On Mon, Apr 19, 2021 at 01:02:34PM -0700, Bart Van Assche wrote: >>>> On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote: >>>>> The list in To: is the one given by get_maintainer.pl. Usualy, I only >>>>> put the ML in Cc: I've run the script on the 2 patches of the serie >>>>> and merged the 2 lists. Everyone is in the To: of the cover letter >>>>> and of the 2 patches. >>>>> >>>>> If Théo is "Tejun Heo" ( (maintainer:WORKQUEUE) ), he is already in >>>>> the To: line. >>>> Linus wants to see a "Cc: ${maintainer}" tag in patches that he receives >>>> from a maintainer and that modify another subsystem than the subsystem >>>> maintained by that maintainer. >>> >>> Really? Do you remember a lore link for this? >> >> Last time I saw Linus mentioning this was a few months ago. >> Unfortunately I cannot find that message anymore. >> >>> Generally I've been junking the CC lines (vs Andrew at the other >>> extreme that often has 10's of CC lines) >> >> Most entries in the MAINTAINERS file have one to three email addresses >> so I'm surprised to read that Cc-ing maintainer(s) could result in tens >> of Cc lines? > > git log mm/ > > commit 2b8305260fb37fc20e13f71e13073304d0a031c8 > Author: Alexander Potapenko > Date: Thu Feb 25 17:19:21 2021 -0800 > > kfence, kasan: make KFENCE compatible with KASAN > > Make KFENCE compatible with KASAN. Currently this helps test KFENCE > itself, where KASAN can catch potential corruptions to KFENCE state, or > other corruptions that may be a result of freepointer corruptions in the > main allocators. > > [akpm@linux-foundation.org: merge fixup] > [andreyknvl@google.com: untag addresses for KFENCE] > Link: https://lkml.kernel.org/r/9dc196006921b191d25d10f6e611316db7da2efc.1611946152.git.andreyknvl@google.com > > Link: https://lkml.kernel.org/r/20201103175841.3495947-7-elver@google.com > Signed-off-by: Marco Elver > Signed-off-by: Alexander Potapenko > Signed-off-by: Andrey Konovalov > Reviewed-by: Dmitry Vyukov > Reviewed-by: Jann Horn > Co-developed-by: Marco Elver > Cc: Andrey Konovalov > Cc: Andrey Ryabinin > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Catalin Marinas > Cc: Christopher Lameter > Cc: Dave Hansen > Cc: David Rientjes > Cc: Eric Dumazet > Cc: Greg Kroah-Hartman > Cc: Hillf Danton > Cc: "H. Peter Anvin" > Cc: Ingo Molnar > Cc: Joern Engel > Cc: Jonathan Corbet > Cc: Joonsoo Kim > Cc: Kees Cook > Cc: Mark Rutland > Cc: Paul E. McKenney > Cc: Pekka Enberg > Cc: Peter Zijlstra > Cc: SeongJae Park > Cc: Thomas Gleixner > Cc: Vlastimil Babka > Cc: Will Deacon > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds But where does that Cc-list come from? If I extract that patch and run the get_maintainer.pl script, the following output appears: $ git format-patch -1 2b8305260fb37fc20e13f71e13073304d0a031c8 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch $ scripts/get_maintainer.pl 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch Alexander Potapenko (maintainer:KFENCE) Marco Elver (maintainer:KFENCE) Dmitry Vyukov (reviewer:KFENCE) Andrey Ryabinin (maintainer:KASAN) Andrey Konovalov (reviewer:KASAN) Andrew Morton (maintainer:MEMORY MANAGEMENT) kasan-dev@googlegroups.com (open list:KFENCE) linux-kernel@vger.kernel.org (open list) linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Additionally, please note that in my email I was referring to the MAINTAINERS file. I do not use the get_maintainers.pl script but instead select the Cc-list manually based on what I find in the MAINTAINERS file. Thanks, Bart.