From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Colin King <colin.king@canonical.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: remove redundant assignment to variable ret
Date: Fri, 22 Nov 2019 12:54:37 -0500 [thread overview]
Message-ID: <58bcf0a3-bd5d-66ad-ced4-9a0660f9ba4b@intel.com> (raw)
In-Reply-To: <20191122154814.87257-1-colin.king@canonical.com>
On 11/22/2019 10:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable ret is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hfi1/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/platform.c b/drivers/infiniband/hw/hfi1/platform.c
> index cbf7faa5038c..36593f2efe26 100644
> --- a/drivers/infiniband/hw/hfi1/platform.c
> +++ b/drivers/infiniband/hw/hfi1/platform.c
> @@ -634,7 +634,7 @@ static void apply_tx_lanes(struct hfi1_pportdata *ppd, u8 field_id,
> u32 config_data, const char *message)
> {
> u8 i;
> - int ret = HCMD_SUCCESS;
> + int ret;
>
> for (i = 0; i < 4; i++) {
> ret = load_8051_config(ppd->dd, field_id, i, config_data);
>
Thanks.
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2019-11-22 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 15:48 [PATCH] IB/hfi1: remove redundant assignment to variable ret Colin King
2019-11-22 17:54 ` Dennis Dalessandro [this message]
2019-11-22 20:26 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58bcf0a3-bd5d-66ad-ced4-9a0660f9ba4b@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).