From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu'
Date: Wed, 24 Jun 2020 14:22:08 -0400 [thread overview]
Message-ID: <5f98c547-1bac-bb05-1c75-cefb8616964a@intel.com> (raw)
In-Reply-To: <20200623005224.492239-1-natechancellor@gmail.com>
On 6/22/2020 8:52 PM, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/infiniband/hw/hfi1/qp.c:198:9: warning: implicit conversion from
> enumeration type 'enum opa_mtu' to different enumeration type 'enum
> ib_mtu' [-Wenum-conversion]
> mtu = OPA_MTU_8192;
> ~ ^~~~~~~~~~~~
> 1 warning generated.
>
> enum opa_mtu extends enum ib_mtu. There are typically two ways to deal
> with this:
>
> * Remove the expected types and just use 'int' for all parameters and
> types.
>
> * Explicitly cast the enums between each other.
>
> This driver chooses to do the later so do the same thing here.
>
> Fixes: 6d72344cf6c4 ("IB/ipoib: Increase ipoib Datagram mode MTU's upper limit")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1062
> Link: https://lore.kernel.org/linux-rdma/20200527040350.GA3118979@ubuntu-s3-xlarge-x86/
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2020-06-24 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 0:52 [PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu' Nathan Chancellor
2020-06-24 18:22 ` Dennis Dalessandro [this message]
2020-06-30 21:05 ` Nathan Chancellor
2020-07-02 14:26 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f98c547-1bac-bb05-1c75-cefb8616964a@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).