From: Saeed Mahameed <saeedm@mellanox.com>
To: "austindh.kim@gmail.com" <austindh.kim@gmail.com>,
"leon@kernel.org" <leon@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Bloch <markb@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alex Vesker <valex@mellanox.com>,
Erez Shitrit <erezsh@mellanox.com>
Subject: Re: [PATCH] net/mlx5: Declare 'rt' as corresponding enum type
Date: Tue, 10 Sep 2019 17:59:31 +0000 [thread overview]
Message-ID: <61418cb7514460e24bfcd431eee9c540e795fcbc.camel@mellanox.com> (raw)
In-Reply-To: <20190910092731.GA173476@LGEARND20B15>
On Tue, 2019-09-10 at 18:27 +0900, Austin Kim wrote:
> When building kernel with clang, we can observe below warning
> message:
>
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9:
> warning: implicit conversion from enumeration type 'enum
> mlx5_reformat_ctx_type'
> to different enumeration type 'enum mlx5dr_action_type' [- Wenum-
> conversion]
> rt = MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1082:9:
> warning: implicit conversion from enumeration type 'enum
> mlx5_reformat_ctx_type'
> to different enumeration type 'enum mlx5dr_action_type' [- Wenum-
> conversion]
> rt = MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL;
> ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1084:51:
> warning: implicit conversion from enumeration type 'enum
> mlx5dr_action_type'
> to different enumeration type 'enum mlx5_reformat_ctx_type'
> [- Wenum-conversion]
> ret = mlx5dr_cmd_create_reformat_ctx(dmn->mdev, rt, data_sz,
> data,
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~
>
> Declare 'rt' as corresponding enum mlx5_reformat_ctx_type type.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
Hi Austin, Thanks for the patch:
We already have a similar patch queued for submission.
https://patchwork.ozlabs.org/patch/1158175/
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> index a02f87f..7d81a77 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> @@ -1074,7 +1074,7 @@ dr_action_create_reformat_action(struct
> mlx5dr_domain *dmn,
> case DR_ACTION_TYP_L2_TO_TNL_L2:
> case DR_ACTION_TYP_L2_TO_TNL_L3:
> {
> - enum mlx5dr_action_type rt;
> + enum mlx5_reformat_ctx_type rt;
>
> if (action->action_type == DR_ACTION_TYP_L2_TO_TNL_L2)
> rt = MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;
next prev parent reply other threads:[~2019-09-10 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 9:27 [PATCH] net/mlx5: Declare 'rt' as corresponding enum type Austin Kim
2019-09-10 17:59 ` Saeed Mahameed [this message]
2019-09-11 11:39 ` Austin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61418cb7514460e24bfcd431eee9c540e795fcbc.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=austindh.kim@gmail.com \
--cc=davem@davemloft.net \
--cc=erezsh@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).