From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7BBC17460 for ; Tue, 5 Nov 2019 14:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BFFA21928 for ; Tue, 5 Nov 2019 14:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728568AbfKEOoF (ORCPT ); Tue, 5 Nov 2019 09:44:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:34178 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725385AbfKEOoF (ORCPT ); Tue, 5 Nov 2019 09:44:05 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 80C58AF3E; Tue, 5 Nov 2019 14:44:03 +0000 (UTC) Subject: Re: [PATCH v2 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER To: Jason Gunthorpe , linux-mm@kvack.org, Jerome Glisse , Ralph Campbell , John Hubbard , Felix.Kuehling@amd.com Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Deucher , Ben Skeggs , Boris Ostrovsky , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Zhou , Dennis Dalessandro , Mike Marciniszyn , Oleksandr Andrushchenko , Petr Cvek , Stefano Stabellini , nouveau@lists.freedesktop.org, xen-devel@lists.xenproject.org, Christoph Hellwig References: <20191028201032.6352-1-jgg@ziepe.ca> <20191028201032.6352-9-jgg@ziepe.ca> <20191101182611.GA31478@ziepe.ca> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <66b50cf6-89ac-81c8-e29a-b34f7f38633e@suse.com> Date: Tue, 5 Nov 2019 15:44:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191101182611.GA31478@ziepe.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 01.11.19 19:26, Jason Gunthorpe wrote: > On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote: >> From: Jason Gunthorpe >> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a library >> set in the kernel). The kconfig convention is to use select for such >> symbols so they are turned on implicitly when the user enables a kconfig >> that needs them. >> >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. >> >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") >> Cc: Oleksandr Andrushchenko >> Cc: Boris Ostrovsky >> Cc: xen-devel@lists.xenproject.org >> Cc: Juergen Gross >> Cc: Stefano Stabellini >> Reviewed-by: Juergen Gross >> Reviewed-by: Oleksandr Andrushchenko >> Signed-off-by: Jason Gunthorpe >> --- >> drivers/xen/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Juergen/Oleksandr/Xen Maintainers: > > Would you take this patch through a xen related tree? The only reason > I had in this series is to make it easier to compile-test the gntdev > changes. Yes, I can take it for 5.5. Juergen