From: Bart Van Assche <bvanassche@acm.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Yamin Friedman <yaminf@mellanox.com>,
kernel test robot <rong.a.chen@intel.com>,
Max Gurtovoy <maxg@mellanox.com>,
LKML <linux-kernel@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg+lists@ziepe.ca>,
linux-rdma@vger.kernel.org, lkp@lists.01.org
Subject: Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143
Date: Fri, 11 Sep 2020 15:00:30 -0700 [thread overview]
Message-ID: <6c86453d-d7ae-a36b-d827-7812999abc96@acm.org> (raw)
In-Reply-To: <e8a240aa-9e9b-3dca-062f-9130b787f29b@acm.org>
On 2020-09-08 19:01, Bart Van Assche wrote:
> The above patch didn't compile, but the patch below does and makes the hang
> disappear. So feel free to add the following to the patch below:
>
> Tested-by: Bart Van Assche <bvanassche@acm.org>
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index c36b4d2b61e0..23ee65a9185f 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -1285,6 +1285,8 @@ static void disable_device(struct ib_device *device)
> remove_client_context(device, cid);
> }
>
> + ib_cq_pool_destroy(device);
> +
> /* Pairs with refcount_set in enable_device */
> ib_device_put(device);
> wait_for_completion(&device->unreg_completion);
> @@ -1328,6 +1330,8 @@ static int enable_device_and_get(struct ib_device *device)
> goto out;
> }
>
> + ib_cq_pool_init(device);
> +
> down_read(&clients_rwsem);
> xa_for_each_marked (&clients, index, client, CLIENT_REGISTERED) {
> ret = add_client_context(device, client);
> @@ -1400,7 +1404,6 @@ int ib_register_device(struct ib_device *device, const char *name)
> goto dev_cleanup;
> }
>
> - ib_cq_pool_init(device);
> ret = enable_device_and_get(device);
> dev_set_uevent_suppress(&device->dev, false);
> /* Mark for userspace that device is ready */
> @@ -1455,7 +1458,6 @@ static void __ib_unregister_device(struct ib_device *ib_dev)
> goto out;
>
> disable_device(ib_dev);
> - ib_cq_pool_destroy(ib_dev);
>
> /* Expedite removing unregistered pointers from the hash table */
> free_netdevs(ib_dev);
Hi Jason,
Please let me know how you want to proceed with this patch.
Thanks,
Bart.
next prev parent reply other threads:[~2020-09-11 22:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 6:09 [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143 kernel test robot
2020-08-02 15:05 ` Bart Van Assche
2020-08-03 6:19 ` Yamin Friedman
2020-08-03 7:27 ` Sagi Grimberg
2020-08-23 21:18 ` Bart Van Assche
2020-08-24 13:30 ` Jason Gunthorpe
2020-09-07 2:58 ` Bart Van Assche
2020-09-08 18:22 ` Jason Gunthorpe
2020-09-09 2:01 ` Bart Van Assche
2020-09-11 22:00 ` Bart Van Assche [this message]
2020-09-12 4:46 ` Yi Zhang
2020-09-14 18:26 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c86453d-d7ae-a36b-d827-7812999abc96@acm.org \
--to=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg+lists@ziepe.ca \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=maxg@mellanox.com \
--cc=rong.a.chen@intel.com \
--cc=sagi@grimberg.me \
--cc=yaminf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).