From: Randy Dunlap <rdunlap@infradead.org>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Danil Kipnis <danil.kipnis@cloud.ionos.com>
Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-next@vger.kernel.org, axboe@kernel.dk, dledford@redhat.com,
bvanassche@acm.org, leon@kernel.org, jinpu.wang@cloud.ionos.com
Subject: Re: [PATCH v2] rnbd/rtrs: pass max segment size from blk user to the rdma library
Date: Thu, 21 May 2020 09:12:59 -0700 [thread overview]
Message-ID: <6de09fa5-5a4f-dec4-7101-8dd27ca4c764@infradead.org> (raw)
In-Reply-To: <20200519234443.GB30609@ziepe.ca>
On 5/19/20 4:44 PM, Jason Gunthorpe wrote:
> On Tue, May 19, 2020 at 01:14:19PM +0200, Danil Kipnis wrote:
>> When Block Device Layer is disabled, BLK_MAX_SEGMENT_SIZE is undefined.
>> The rtrs is a transport library and should compile independently of the
>> block layer. The desired max segment size should be passed down by the
>> user.
>>
>> Introduce max_segment_size parameter for the rtrs_clt_open() call.
>>
>> Fixes: f7a7a5c228d4 ("block/rnbd: client: main functionality")
>> Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
>> Fixes: cb80329c9434 ("RDMA/rtrs: client: private header with client structs and functions")
>> Fixes: b5c27cdb094e ("RDMA/rtrs: public interface header to establish RDMA connections")
>>
>> Signed-off-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>> ---
>> v1->v2 Add Fixes lines.
>
> Applied to for-next, thanks
Hi Jason,
Does your "for-next" feed into linux-next?
I am still seeing this build error today (linux-next 20200521).
thanks.
--
~Randy
next prev parent reply other threads:[~2020-05-21 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200518205725.72eb3148@canb.auug.org.au>
2020-05-18 15:00 ` linux-next: Tree for May 18 (drivers/infiniband/ulp/rtrs/rtrs-clt.c) Randy Dunlap
2020-05-19 6:55 ` Danil Kipnis
2020-05-19 8:01 ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Danil Kipnis
2020-05-19 8:01 ` [PATCH 1/1] rnbd/rtrs: pass max segment size from blk user to the rdma library Danil Kipnis
2020-05-19 8:48 ` Leon Romanovsky
2020-05-19 9:14 ` Danil Kipnis
2020-05-19 15:42 ` Leon Romanovsky
2020-05-19 11:14 ` [PATCH v2] " Danil Kipnis
2020-05-19 15:04 ` Randy Dunlap
2020-05-19 23:44 ` Jason Gunthorpe
2020-05-21 16:12 ` Randy Dunlap [this message]
2020-05-21 20:00 ` Jason Gunthorpe
2020-05-19 8:45 ` [PATCH 0/1] Fix RTRS compilation with block layer disabled Leon Romanovsky
2020-05-19 23:34 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de09fa5-5a4f-dec4-7101-8dd27ca4c764@infradead.org \
--to=rdunlap@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jinpu.wang@cloud.ionos.com \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).