From: Maor Gottlieb <maorg@mellanox.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1 11/11] RDMA/mlx5: Add support to get MR resource in RAW format
Date: Tue, 9 Jun 2020 11:27:08 +0300 [thread overview]
Message-ID: <7840e2c7-8e9a-834d-b199-b1ebfa31fee3@mellanox.com> (raw)
In-Reply-To: <20200608114654.GS6578@ziepe.ca>
On 6/8/2020 2:46 PM, Jason Gunthorpe wrote:
> On Sun, Jun 07, 2020 at 11:47:11AM +0300, Maor Gottlieb wrote:
>> On 6/2/2020 4:23 PM, Leon Romanovsky wrote:
>>> On Tue, Jun 02, 2020 at 09:27:02AM -0300, Jason Gunthorpe wrote:
>>>> On Tue, Jun 02, 2020 at 09:21:18AM +0300, Leon Romanovsky wrote:
>>>>> On Mon, Jun 01, 2020 at 09:26:46AM -0300, Jason Gunthorpe wrote:
>>>>>> On Sun, May 31, 2020 at 12:54:14PM +0300, Leon Romanovsky wrote:
>>>>>>> On Fri, May 29, 2020 at 08:31:21PM -0300, Jason Gunthorpe wrote:
>>>>>>>> On Wed, May 27, 2020 at 04:54:08PM +0300, Leon Romanovsky wrote:
>>>>>>>>> From: Maor Gottlieb <maorg@mellanox.com>
>>>>>>>>>
>>>>>>>>> Add support to get MR (mkey) resource dump in RAW format.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
>>>>>>>>> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>>>>>>>>> drivers/infiniband/hw/mlx5/restrack.c | 3 ++-
>>>>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>>>>
>>>>>>>>> diff --git a/drivers/infiniband/hw/mlx5/restrack.c b/drivers/infiniband/hw/mlx5/restrack.c
>>>>>>>>> index 9e1389b8dd9f..834886536127 100644
>>>>>>>>> +++ b/drivers/infiniband/hw/mlx5/restrack.c
>>>>>>>>> @@ -116,7 +116,8 @@ int mlx5_ib_fill_res_mr_entry(struct sk_buff *msg,
>>>>>>>>> struct nlattr *table_attr;
>>>>>>>>>
>>>>>>>>> if (raw)
>>>>>>>>> - return -EOPNOTSUPP;
>>>>>>>>> + return fill_res_raw(msg, mr->dev, MLX5_SGMT_TYPE_PRM_QUERY_MKEY,
>>>>>>>>> + mlx5_mkey_to_idx(mr->mmkey.key));
>>>>>>>> None of the raw functions actually share any code with the non raw
>>>>>>>> part, why are the in the same function? In fact all the implemenations
>>>>>>>> just call some other function for raw.
>>>>>>>>
>>>>>>>> To me this looks like they should should all be a new op
>>>>>>>> 'fill_raw_res_mr_entry' and drop the 'bool'
>>>>>>> I don't think that this is right approach, we already created ops per-objects
>>>>>>> o remove API multiplexing. Extra de-duplication will create too much ops
>>>>>>> without any real benefit.
>>>>>> If there is no code sharing then they should not be in the same
>>>>>> function at all. More ops is not really a problem.
>>>>> Logically they are the same, user asks to get object property, driver returns.
>>>> I'm starting to think it is also a mistake to have the same netlink op
>>>> and trigger it by an inbound attribute. Are there other examples of
>>>> that in netlink? Feels wrong
>>> I have no idea, don't see it in devlink.c
>> Jason, do you mean trigger the raw by inbound attribute? I don't see a
>> reason why not do that. Netlink attributes used for input and
>> output.
> What examples do you have where the input attribute completely changes
> the output format?
>
> Jason
I don't have. Anyway I am planning to send v2 with new netlink ops.
next prev parent reply other threads:[~2020-06-09 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:53 [PATCH rdma-next v1 00/11] RAW format dumps through RDMAtool Leon Romanovsky
2020-05-27 13:53 ` [PATCH mlx5-next v1 01/11] net/mlx5: Export resource dump interface Leon Romanovsky
2020-05-27 13:53 ` [PATCH mlx5-next v1 02/11] net/mlx5: Add support in query QP, CQ and MKEY segments Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 03/11] RDMA/core: Don't call fill_res_entry for PD Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 04/11] RDMA: Add dedicated MR resource tracker function Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 05/11] RDMA: Add dedicated CQ " Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 06/11] RDMA: Add dedicated QP " Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 07/11] RDMA: Add dedicated CM_ID " Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 08/11] RDMA: Add support to dump resource tracker in RAW format Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 09/11] RDMA/mlx5: Add support to get QP resource in raw format Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 10/11] RDMA/mlx5: Add support to get CQ resource in RAW format Leon Romanovsky
2020-05-27 13:54 ` [PATCH rdma-next v1 11/11] RDMA/mlx5: Add support to get MR " Leon Romanovsky
2020-05-29 23:31 ` Jason Gunthorpe
2020-05-31 9:54 ` Leon Romanovsky
2020-06-01 12:26 ` Jason Gunthorpe
2020-06-02 6:21 ` Leon Romanovsky
2020-06-02 12:27 ` Jason Gunthorpe
2020-06-02 13:23 ` Leon Romanovsky
2020-06-07 8:47 ` Maor Gottlieb
2020-06-08 11:46 ` Jason Gunthorpe
2020-06-09 8:27 ` Maor Gottlieb [this message]
2020-06-09 11:42 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7840e2c7-8e9a-834d-b199-b1ebfa31fee3@mellanox.com \
--to=maorg@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).