Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: Andrew Boyer <aboyer@pensando.io>
To: linux-rdma@vger.kernel.org
Cc: Allen Hubbe <allenbh@pensando.io>,
	Leon Romanovsky <leonro@mellanox.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Which print functions to use during early device create?
Date: Fri, 14 Feb 2020 17:23:29 -0500
Message-ID: <7A6D8934-9D25-4BDF-BCBA-B37CAA064677@pensando.io> (raw)

When we get a NETDEV_REGISTER event, we get a pointer to the existing struct netdev. If all goes well, we end up creating an associated struct ib_device.

How should we log an error that happens in-between, preventing us from creating the ib_device?

netdev_err() on the ndev?
dev_err() on the underlying struct device?
pr_err()?

Thanks,
Andrew


             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 22:23 Andrew Boyer [this message]
2020-02-15  0:11 ` Jason Gunthorpe

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7A6D8934-9D25-4BDF-BCBA-B37CAA064677@pensando.io \
    --to=aboyer@pensando.io \
    --cc=allenbh@pensando.io \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git