linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Dan Aloni <dan@kernelim.com>
Cc: linux-rdma <linux-rdma@vger.kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] svcrdma: fix bounce buffers for non-zero page offsets
Date: Fri, 2 Oct 2020 10:54:28 -0400	[thread overview]
Message-ID: <7DE1BF37-DF5E-47F2-A24C-A80ED20956CE@oracle.com> (raw)
In-Reply-To: <20201002144827.984306-1-dan@kernelim.com>

Hi Dan-

> On Oct 2, 2020, at 10:48 AM, Dan Aloni <dan@kernelim.com> wrote:
> 
> This was discovered using O_DIRECT and small unaligned file offsets
> at the client side.
> 
> Fixes: e248aa7be86 ("svcrdma: Remove max_sge check at connect time")
> Signed-off-by: Dan Aloni <dan@kernelim.com>
> ---
> net/sunrpc/xprtrdma/svc_rdma_sendto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> index 7b94d971feb3..c991eb1fd4e3 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> @@ -638,7 +638,7 @@ static int svc_rdma_pull_up_reply_msg(struct svcxprt_rdma *rdma,
> 		while (remaining) {
> 			len = min_t(u32, PAGE_SIZE - pageoff, remaining);
> 
> -			memcpy(dst, page_address(*ppages), len);
> +			memcpy(dst, page_address(*ppages) + pageoff, len);

I'm assuming the only relevant place that sets xdr->page_base
is nfsd_splice_actor() ?


> 			remaining -= len;
> 			dst += len;
> 			pageoff = 0;
> -- 
> 2.26.2
> 

--
Chuck Lever




  reply	other threads:[~2020-10-02 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 14:48 [PATCH] svcrdma: fix bounce buffers for non-zero page offsets Dan Aloni
2020-10-02 14:54 ` Chuck Lever [this message]
2020-10-02 15:18   ` Dan Aloni
2020-10-02 15:23     ` Chuck Lever
2020-10-02 19:33       ` [PATCH v2] svcrdma: fix bounce buffers for unaligned offsets and multiple pages Dan Aloni
2020-10-14 21:26         ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7DE1BF37-DF5E-47F2-A24C-A80ED20956CE@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=dan@kernelim.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).