* [PATCH][next] net/mlx5e: fix memory leak of tls
@ 2020-06-30 15:16 Colin King
2020-06-30 16:30 ` Tariq Toukan
2020-06-30 20:38 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-06-30 15:16 UTC (permalink / raw)
To: Boris Pismenny, Saeed Mahameed, Leon Romanovsky,
David S . Miller, Jakub Kicinski, Tariq Toukan, netdev,
linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The error return path when create_singlethread_workqueue fails currently
does not kfree tls and leads to a memory leak. Fix this by kfree'ing
tls before returning -ENOMEM.
Addresses-Coverity: ("Resource leak")
Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
index 99beb928feff..fee991f5ee7c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
@@ -232,8 +232,10 @@ int mlx5e_tls_init(struct mlx5e_priv *priv)
return -ENOMEM;
tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx");
- if (!tls->rx_wq)
+ if (!tls->rx_wq) {
+ kfree(tls);
return -ENOMEM;
+ }
priv->tls = tls;
return 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net/mlx5e: fix memory leak of tls
2020-06-30 15:16 [PATCH][next] net/mlx5e: fix memory leak of tls Colin King
@ 2020-06-30 16:30 ` Tariq Toukan
2020-06-30 20:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tariq Toukan @ 2020-06-30 16:30 UTC (permalink / raw)
To: Colin King, Boris Pismenny, Saeed Mahameed, Leon Romanovsky,
David S . Miller, Jakub Kicinski, netdev, linux-rdma
Cc: kernel-janitors, linux-kernel
On 6/30/2020 6:16 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error return path when create_singlethread_workqueue fails currently
> does not kfree tls and leads to a memory leak. Fix this by kfree'ing
> tls before returning -ENOMEM.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> index 99beb928feff..fee991f5ee7c 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c
> @@ -232,8 +232,10 @@ int mlx5e_tls_init(struct mlx5e_priv *priv)
> return -ENOMEM;
>
> tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx");
> - if (!tls->rx_wq)
> + if (!tls->rx_wq) {
> + kfree(tls);
> return -ENOMEM;
> + }
>
> priv->tls = tls;
> return 0;
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net/mlx5e: fix memory leak of tls
2020-06-30 15:16 [PATCH][next] net/mlx5e: fix memory leak of tls Colin King
2020-06-30 16:30 ` Tariq Toukan
@ 2020-06-30 20:38 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-30 20:38 UTC (permalink / raw)
To: colin.king
Cc: borisp, saeedm, leon, kuba, tariqt, netdev, linux-rdma,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Tue, 30 Jun 2020 16:16:46 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The error return path when create_singlethread_workqueue fails currently
> does not kfree tls and leads to a memory leak. Fix this by kfree'ing
> tls before returning -ENOMEM.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 1182f3659357 ("net/mlx5e: kTLS, Add kTLS RX HW offload support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-30 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 15:16 [PATCH][next] net/mlx5e: fix memory leak of tls Colin King
2020-06-30 16:30 ` Tariq Toukan
2020-06-30 20:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).