From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E0DC33CB1 for ; Fri, 17 Jan 2020 09:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E9B620730 for ; Fri, 17 Jan 2020 09:51:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YD19WJUY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbgAQJu6 (ORCPT ); Fri, 17 Jan 2020 04:50:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:29382 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726085AbgAQJut (ORCPT ); Fri, 17 Jan 2020 04:50:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579254648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oJRJOOtAJx4rABOIyWYmHnWYUrcoGrCqCdDRh2YY52I=; b=YD19WJUYZAJBREAk8ub3j0ctH0SOOPxc3Gn6Yaa9Mrn59JcDAZMvuVtG/R7RI4y738i+Di Pd+Mo+sOjox0XRP1ZZD/t/+WtySQnVUsxrwYCqtJd5YbKR2J+qGdmlYGiUHUPNCBNbpksW U6Yfw5ac+GEBbddZgFWoa3z0WzMQvjM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-upQ474CTO1WTuWcfZcdR_A-1; Fri, 17 Jan 2020 04:50:47 -0500 X-MC-Unique: upQ474CTO1WTuWcfZcdR_A-1 Received: by mail-lf1-f72.google.com with SMTP id w72so4244566lff.20 for ; Fri, 17 Jan 2020 01:50:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=oJRJOOtAJx4rABOIyWYmHnWYUrcoGrCqCdDRh2YY52I=; b=B5m9+nZ5MgmeNNT2Zu5jYOskQs0DLOCrFPF8hwvR4YoBy5cl2pT8wlI2vWBV7LXc63 S+zE+GItTRrHMFB4q0dMSLIaG1HzR5l1cTvQzPbeVEZolzpQOvdmM/sr3xln6QkM02Oz r+MvfAhfZuUcE4V+7rU3vE9pRrCiSp7xYaCOew2mOamU7kOLmYPJ2QGlpHdbd3XfJLka Qp12qvmi/sRl0KCuxA+8oL9p5Wv6goQwGv9gi3eVD4fsS2wwuEUArLW4SZyz2FU6yXHA DwMhFLq/TbYtB2fnyOmJdjj4tE6QOFPbkFC8/IhhCs1zke60bNAm/aoP2sYz3ir6tjQu cthg== X-Gm-Message-State: APjAAAUimwr4I0sfNn3E+QEvWnb4pOQSA0ywzjeovpS6nkZGAzDVR4b/ XsI5xiNdkvsJaeQmeAUC/JGPUk/nldBpzI97fzNZ5ulAa2wBrSySjpFc9lCrCYv/zC4l1f1aJyk ISWZaPvafeId/o2sD9IZAuA== X-Received: by 2002:a2e:3a0c:: with SMTP id h12mr5110075lja.200.1579254646255; Fri, 17 Jan 2020 01:50:46 -0800 (PST) X-Google-Smtp-Source: APXvYqxVH1mvGN7jFxhc1CGWH4ht8uwwpUWB8gY29//W0Sp2WPWefYaaYkajI0yi/HmyV1E0o/g6WQ== X-Received: by 2002:a2e:3a0c:: with SMTP id h12mr5110047lja.200.1579254646128; Fri, 17 Jan 2020 01:50:46 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id s9sm14012128ljh.90.2020.01.17.01.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 01:50:45 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D7C9C1804D6; Fri, 17 Jan 2020 10:50:44 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , Networking , bpf , open list , linux-rdma@vger.kernel.org, "open list\:KERNEL SELFTEST FRAMEWORK" , clang-built-linux@googlegroups.com Subject: Re: [PATCH bpf-next v3 09/11] selftests: Remove tools/lib/bpf from include path In-Reply-To: References: <157918093154.1357254.7616059374996162336.stgit@toke.dk> <157918094179.1357254.14428494370073273452.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 17 Jan 2020 10:50:44 +0100 Message-ID: <87o8v2qumj.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Andrii Nakryiko writes: > On Thu, Jan 16, 2020 at 2:41 PM Andrii Nakryiko > wrote: >> >> On Thu, Jan 16, 2020 at 5:28 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> > >> > From: Toke H=C3=B8iland-J=C3=B8rgensen >> > >> > To make sure no new files are introduced that doesn't include the bpf/ >> > prefix in its #include, remove tools/lib/bpf from the include path >> > entirely. >> > >> > Instead, we introduce a new header files directory under the scratch t= ools/ >> > dir, and add a rule to run the 'install_headers' rule from libbpf to h= ave a >> > full set of consistent libbpf headers in $(OUTPUT)/tools/include/bpf, = and >> > then use $(OUTPUT)/tools/include as the include path for selftests. >> > >> > For consistency we also make sure we put all the scratch build files f= rom >> > other bpftool and libbpf into tools/build/, so everything stays within >> > selftests/. >> > >> > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> > --- > > BTW, this change also now forces full rebuild regardless if anything > changed or not :( It does? Hmm, that was not intentional (I was mostly focused on making sure a clean make worked, not the opposite). I'll see if I can't fix that as well... -Toke