From: Noa Osherovich <noaos@mellanox.com>
To: Jason Gunthorpe <jgg@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-core 03/14] build: Add pyverbs-based test to the build
Date: Sun, 1 Sep 2019 13:30:56 +0000 [thread overview]
Message-ID: <88435e1e-676b-f948-1c34-22cd471af4c9@mellanox.com> (raw)
In-Reply-To: <20190822165247.GB8325@mellanox.com>
On 8/22/2019 7:52 PM, Jason Gunthorpe wrote:
> On Thu, Aug 22, 2019 at 01:18:24PM -0300, Leon Romanovsky wrote:
>> On Tue, Aug 20, 2019 at 01:00:47PM +0000, Noa Osherovich wrote:
>>> On 8/19/2019 4:50 PM, Jason Gunthorpe wrote:
>>>
>>>> I'd prefer run_tests to be in the tests directory..
>>>>
>>>> Jason
>>> PR was updated
>> 1.
>> IMHO, run_tests.py should be placed inside tests directory too and not
>> only installed into tests/.
> Yes, this is what I ment. The file should be in tests/ and it should
> be built into build/bin, and installed into the examples
>> 2.
>> Execution of run_tests.py produces a lot of untracked filed
>> ➜ rdma-core git:(noaos-pr-tests) ✗ git st
>> On branch noaos-pr-tests
>> Untracked files:
>> (use "git add <file>..." to include in what will be committed)
>>
>> pyverbs/__init__.pyc
>> pyverbs/pyverbs_error.pyc
>> tests/__init__.pyc
>> tests/base.pyc
>> tests/test_addr.pyc
>> tests/test_cq.pyc
>> tests/test_device.pyc
>> tests/test_mr.pyc
>> tests/test_odp.pyc
>> tests/test_pd.pyc
>> tests/test_qp.pyc
> *.pyc will have to be added to the .gitignore
>> 3. run_tests.py lacks of python3 shebang
> Originally it was not installed, so this was fine, as the build/bin
> script does all the required setup, however now that it is to be
> installed it should have the #! - and it should also work without any
> trouble from it's example location.
>
> Jason
PR was updated.
Thanks,
Noa
next prev parent reply other threads:[~2019-09-01 13:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 6:58 [PATCH rdma-core 00/14] rdma-core tests infrastructure Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 01/14] pyverbs/tests: Rename base class Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 02/14] pyverbs: Move tests to a stand-alone directory Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 03/14] build: Add pyverbs-based test to the build Noa Osherovich
2019-08-19 13:50 ` Jason Gunthorpe
2019-08-20 13:00 ` Noa Osherovich
2019-08-22 16:18 ` Leon Romanovsky
2019-08-22 16:52 ` Jason Gunthorpe
2019-09-01 13:30 ` Noa Osherovich [this message]
2019-09-09 10:29 ` Leon Romanovsky
2019-09-09 10:39 ` Noa Osherovich
2019-09-09 11:26 ` Leon Romanovsky
2019-09-09 11:30 ` Noa Osherovich
2019-09-09 11:38 ` Leon Romanovsky
2019-09-09 11:34 ` Leon Romanovsky
2019-08-19 6:58 ` [PATCH rdma-core 04/14] tests: BaseResources Class Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 05/14] tests: RDMATestCase Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 06/14] tests: TrafficResources class Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 07/14] tests: RCResources and UDResources classes Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 08/14] tests: ODP requires decorator Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 09/14] tests: Add traffic helper methods Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 10/14] tests: Add ODP RC test Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 11/14] tests: Add ODP UD test Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 12/14] tests: Fix test locating process Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 13/14] Documentation: Add background for rdma-core tests Noa Osherovich
2019-08-19 6:58 ` [PATCH rdma-core 14/14] tests: Unify API tests' output Noa Osherovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88435e1e-676b-f948-1c34-22cd471af4c9@mellanox.com \
--to=noaos@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).