From: Haakon Bugge <haakon.bugge@oracle.com>
To: "ice_yangxiao@163.com" <ice_yangxiao@163.com>
Cc: OFED mailing list <linux-rdma@vger.kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Xiao Yang <yangx.jy@fujitsu.com>
Subject: Re: [PATCH] RDMA/rxe: Remove the repeated 'mr->umem = umem'
Date: Fri, 2 Jul 2021 12:58:40 +0000 [thread overview]
Message-ID: <98F0E5B6-12A4-4303-9060-6D8232DF2694@oracle.com> (raw)
In-Reply-To: <20210702123024.37025-1-ice_yangxiao@163.com>
> On 2 Jul 2021, at 14:30, ice_yangxiao@163.com wrote:
>
> From: Xiao Yang <yangx.jy@fujitsu.com>
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
LGTM,
Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
Not related to the commit, but whilst reviewing, it looks to me as the second "goto err1" in rxe_mr_init_user() has a memleak because mr->map is not deallocated.
Thxs, Håkon
>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 6aabcb4de235..487cefc015b8 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> goto err1;
> }
>
> - mr->umem = umem;
> num_buf = ib_umem_num_pages(umem);
>
> rxe_mr_init(access, mr);
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-07-02 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 12:30 [PATCH] RDMA/rxe: Remove the repeated 'mr->umem = umem' ice_yangxiao
2021-07-02 12:58 ` Haakon Bugge [this message]
2021-07-05 1:38 ` yangx.jy
2021-07-04 21:43 ` Bob Pearson
2021-07-15 18:01 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98F0E5B6-12A4-4303-9060-6D8232DF2694@oracle.com \
--to=haakon.bugge@oracle.com \
--cc=ice_yangxiao@163.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).