From: Gal Pressman <galpress@amazon.com>
To: Max Gurtovoy <maxg@mellanox.com>, <bvanassche@acm.org>,
<jgg@mellanox.com>, <linux-rdma@vger.kernel.org>,
<dledford@redhat.com>, <leon@kernel.org>
Cc: <sagi@grimberg.me>, <israelr@mellanox.com>, <shlomin@mellanox.com>
Subject: Re: [PATCH 0/8 v1] Remove FMR support from RDMA drivers
Date: Thu, 14 May 2020 19:00:10 +0300 [thread overview]
Message-ID: <995f4a0d-4026-de1e-c604-ca56801e5193@amazon.com> (raw)
In-Reply-To: <20200514120305.189738-1-maxg@mellanox.com>
On 14/05/2020 15:02, Max Gurtovoy wrote:
> This series removes the support for FMR mode to register memory. This ancient
> mode is unsafe and not maintained/tested in the last few years. It also doesn't
> have any reasonable advantage over other memory registration methods such as
> FRWR (that is implemented in all the recent RDMA adapters). This series should
> be reviewed and approved by the maintainer of the effected drivers and I
> suggest to test it as well.
>
> The tests that I made for this series (fio benchmarks and fio verify data):
> 1. iSER initiator on ConnectX-4
> 2. iSER initiator on ConnectX-3
> 3. SRP initiator on ConnectX-4 (loopback to SRP target)
> 4. SRP initiator on ConnectX-3
>
> Not tested:
> 1. RDS
> 2. mthca
> 3. rdmavt
I think there are a few leftovers:
From f289a67b47e03d268469211065bf114cbb1c7125 Mon Sep 17 00:00:00 2001
From: Gal Pressman <galpress@amazon.com>
Date: Wed, 13 May 2020 10:49:09 +0300
Subject: [PATCH] RDMA/mlx5: Remove FMR leftovers
Remove a few leftovers from FMR functionality which are no longer used.
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index 482b54eb9764..40c461017763 100644
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -675,12 +675,6 @@ struct umr_common {
struct semaphore sem;
};
-enum {
- MLX5_FMR_INVALID,
- MLX5_FMR_VALID,
- MLX5_FMR_BUSY,
-};
-
struct mlx5_cache_ent {
struct list_head head;
/* sync access to the cahce entry
@@ -1253,8 +1247,6 @@ int mlx5_query_mad_ifc_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props);
int mlx5_ib_query_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props);
-int mlx5_ib_init_fmr(struct mlx5_ib_dev *dev);
-void mlx5_ib_cleanup_fmr(struct mlx5_ib_dev *dev);
void mlx5_ib_cont_pages(struct ib_umem *umem, u64 addr,
unsigned long max_page_shift,
int *count, int *shift,
--
2.26.2
next prev parent reply other threads:[~2020-05-14 16:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 12:02 [PATCH 0/8 v1] Remove FMR support from RDMA drivers Max Gurtovoy
2020-05-14 12:02 ` [PATCH 1/8] RDMA/mlx4: remove FMR support for memory registration Max Gurtovoy
2020-05-14 12:02 ` [PATCH 2/8] RDMA/rds: " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 3/8] RDMA/mthca: " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 4/8] RDMA/rdmavt: remove FMR " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 5/8] RDMA/iser: Remove support for " Max Gurtovoy
2020-05-14 12:03 ` [PATCH 6/8] RDMA/srp: remove " Max Gurtovoy
2020-05-14 14:02 ` Bart Van Assche
2020-05-14 12:03 ` [PATCH 7/8] RDMA/core: remove FMR pool API Max Gurtovoy
2020-05-14 12:03 ` [PATCH 8/8] RDMA/core: remove FMR device ops Max Gurtovoy
2020-05-14 15:13 ` [PATCH 0/8 v1] Remove FMR support from RDMA drivers Aron Silverton
2020-05-14 18:18 ` santosh.shilimkar
2020-05-14 19:42 ` Max Gurtovoy
2020-05-14 22:23 ` Sagi Grimberg
2020-05-14 23:41 ` santosh.shilimkar
2020-05-15 16:52 ` Tom Talpey
2020-05-15 18:59 ` Sagi Grimberg
2020-05-17 10:51 ` Max Gurtovoy
2020-05-18 16:34 ` santosh.shilimkar
2020-05-15 0:37 ` Max Gurtovoy
2020-05-14 16:00 ` Gal Pressman [this message]
2020-05-17 10:37 ` Max Gurtovoy
2020-05-18 15:20 ` Dennis Dalessandro
2020-05-18 18:10 ` Jason Gunthorpe
2020-05-19 13:43 ` Dennis Dalessandro
2020-05-19 13:53 ` Jason Gunthorpe
2020-05-19 14:19 ` Leon Romanovsky
2020-05-19 14:26 ` Dennis Dalessandro
2020-05-19 14:30 ` Jason Gunthorpe
2020-05-19 14:37 ` Dennis Dalessandro
2020-05-23 22:08 ` Jason Gunthorpe
2020-05-24 1:27 ` Tom Talpey
2020-05-26 15:38 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995f4a0d-4026-de1e-c604-ca56801e5193@amazon.com \
--to=galpress@amazon.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).