linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rafi Wiener <rafiw@mellanox.com>
To: Doug Ledford <dledford@redhat.com>,
	Leon Romanovsky <leon@kernel.org>,
	Jason Gunthorpe <jgg@mellanox.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>,
	Bodong Wang <bodong@mellanox.com>,
	Oleg Kuporosov <olegk@mellanox.com>,
	Leon Romanovsky <leonro@mellanox.com>
Subject: RE: [PATCH rdma-rc] RDMA/mlx5: Clear old rate limit when closing QP
Date: Sun, 20 Oct 2019 08:59:26 +0000	[thread overview]
Message-ID: <AM0PR05MB501046FE02320C485CD37CA8CE6E0@AM0PR05MB5010.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <cca910c4040961729f0f4d0ad248b6b5684c80eb.camel@redhat.com>

Hi Doug,
The issue is when you have a few QPs with the same rate limit you remove the rate twice from the table instead of once. This causes issue, no racing or stressing occurs.
Rafi 

-----Original Message-----
From: Doug Ledford <dledford@redhat.com> 
Sent: Thursday, October 17, 2019 11:12 PM
To: Leon Romanovsky <leon@kernel.org>; Jason Gunthorpe <jgg@mellanox.com>
Cc: Rafi Wiener <rafiw@mellanox.com>; RDMA mailing list <linux-rdma@vger.kernel.org>; Bodong Wang <bodong@mellanox.com>; Oleg Kuporosov <olegk@mellanox.com>; Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH rdma-rc] RDMA/mlx5: Clear old rate limit when closing QP

On Wed, 2019-10-02 at 15:02 +0300, Leon Romanovsky wrote:
> From: Rafi Wiener <rafiw@mellanox.com>
> 
> Before QP is closed it changes to ERROR state, when this happens the 
> QP was left with old rate limit that was already removed from the 
> table.
> 
> Fixes: 7d29f349a4b9 ("IB/mlx5: Properly adjust rate limit on QP state
> transitions")
> Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
> Signed-off-by: Oleg Kuporosov <olegk@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

If you are in the process of closing the queue pair, does this solve some sort of multi-close race, or is it just being pedantic before freeing the qp struct?

I took it regardless, just curious.

--
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

      parent reply	other threads:[~2019-10-20  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 12:02 [PATCH rdma-rc] RDMA/mlx5: Clear old rate limit when closing QP Leon Romanovsky
2019-10-17 20:12 ` Doug Ledford
2019-10-20  5:27   ` Leon Romanovsky
2019-10-20  8:59   ` Rafi Wiener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB501046FE02320C485CD37CA8CE6E0@AM0PR05MB5010.eurprd05.prod.outlook.com \
    --to=rafiw@mellanox.com \
    --cc=bodong@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=leon@kernel.org \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=olegk@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).