From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Amrani, Ram" Subject: RE: [PATCH rdma-core 07/10] providers: Use the new common PCI matching infrastructure Date: Sun, 24 Sep 2017 13:29:09 +0000 Message-ID: References: <1505855931-4956-1-git-send-email-jgunthorpe@obsidianresearch.com> <1505855931-4956-8-git-send-email-jgunthorpe@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1505855931-4956-8-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Cc: Devesh Sharma , Mike Marciniszyn , Dennis Dalessandro , Tatyana Nikolova , Yishai Hadas , Vladimir Sokolovsky , "Elior, Ariel" , Adit Ranadive , "moderated list:HF1 USERSPACE PROVIDER (for hf1.ko)" , "open list:IPATH/QIB USERSPACE PROVIDER (for ib_qib.ko)" , "pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org For qedr: Signed-off-by: Ram Amrani See the following question though, not directly related to the patch: > static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sy= sfs_dev) > { > struct qelr_device *dev; > @@ -269,7 +238,7 @@ static const struct verbs_device_ops qelr_dev_ops =3D= { > .name =3D "qelr", Should this be the driver name or the library name? The driver name is qedr and the library name is libqedr. It is usually abbr= eviated to qelr. I reckon that this should be the driver name (otherwise auto-load will fail= ?!). > .match_min_abi_version =3D QELR_ABI_VERSION, > .match_max_abi_version =3D QELR_ABI_VERSION, > - .match_device =3D qedr_device_match, > + .match_table =3D hca_table, > .alloc_device =3D qedr_device_alloc, > .uninit_device =3D qelr_uninit_device, > .alloc_context =3D qelr_alloc_context, Following the above, and still not directly related to the patch, is usage = of both names. I'll fix this after your submission to qelr_... Thanks, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html