RE: Re: siw_cm.c:255 siw_cep_put+0x125/0x130 kernel warning while testing blktests srp/002 v5.17-rc7

[Bernard Metzler <BMT@zurich.ibm.com>]

> -----Original Message-----
> From: Luis Chamberlain <mcgrof@infradead.org> On Behalf Of Luis
> Chamberlain
> Sent: Thursday, 5 May 2022 14:48
> To: Bernard Metzler <BMT@zurich.ibm.com>
> Cc: Cheng Xu <chengyou@linux.alibaba.com>; Bart Van Assche
> <bvanassche@acm.org>; linux-block@vger.kernel.org; linux-
> rdma@vger.kernel.org; Pankaj Raghav <pankydev8@gmail.com>; Pankaj Raghav
> <p.raghav@samsung.com>
> Subject: [EXTERNAL] Re: siw_cm.c:255 siw_cep_put+0x125/0x130 kernel
> warning while testing blktests srp/002 v5.17-rc7
> 
> On Thu, May 05, 2022 at 11:42:55AM +0000, Bernard Metzler wrote:
> >
> > > -----Original Message-----
> > > >
> > > > *poke*
> > > >
> > > > Would be good to get a fix merged. And if a patch is posted does
> this
> > > > need to go to stable?
> > > >
> > > >    Luis
> > >
> > > The patch has been accepted and merged to for-rc, see:
> > >
> > > INVALID URI REMOVED
> > >
> 3A__lore.kernel.org_all_d528d83466c44687f3872eadcb8c184528b2e2d4.1650526
> > > 554.git.chengyou-40linux.alibaba.com_T_&d=DwICaQ&c=jf_iaSHvJObTbx-
> > > siA1ZOg&r=2TaYXQ0T-
> r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=gj2AyKoOM_k9fYF-
> > >
> _XQ4HcYw_viOIwl6lDNPHqp7L1y2OiVRWvZkTFGFHSSZInor&s=P_HaXIXt9mBbCeBNBLsWe
> > > RTz5hvnUGUvObzs8lowzCM&e=
> > >
> > > I think this patch need not be merged back to stable, because the
> issue
> > > is not a functional problem, but only produce a WARN in dmesg.
> > >
> > > Thanks,
> > > Cheng Xu
> >
> > I agree. It does not fix a memory leak or some such.
> 
> If the warning triggers on older kernels it means testing using this
> driver will fail and those tests will be skipped. In this case the
> test srp/002 would be skipped unless this is fixed to not trigger
> a kernel warning.
> 
>   Luis


Ah okay.
Since it was an easy fix, I'd go for merging back to stable,
if it's not too much of an effort.

Thanks!
Bernard.