From: Chuck Lever <chuck.lever@oracle.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, aron.silverton@oracle.com
Subject: Re: [PATCH RFC 0/3] IB CM tracepoints
Date: Mon, 20 Jul 2020 10:05:09 -0400 [thread overview]
Message-ID: <C478FD1F-CBA5-418B-B55D-37B5F4FF7408@oracle.com> (raw)
In-Reply-To: <20200720140013.GG25301@ziepe.ca>
> On Jul 20, 2020, at 10:00 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>
> On Fri, Jul 10, 2020 at 12:32:28PM -0400, Chuck Lever wrote:
>>
>>
>>> On Jul 10, 2020, at 11:17 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>>>
>>> On Fri, Jul 10, 2020 at 10:06:01AM -0400, Chuck Lever wrote:
>>>> Hi-
>>>>
>>>> This is a Request For Comments.
>>>>
>>>> Oracle has an interest in a common observability infrastructure in
>>>> the RDMA core and ULPs. One alternative for this infrastructure is
>>>> to introduce static tracepoints that can also be used as hooks for
>>>> eBPF scripts, replacing infrastructure that is based on printk.
>>>
>>> Don't we already have tracepoints in CM, why is adding more RFC?
>>
>> One of these patches _replaces_ printk calls with tracepoints.
>> Is that OK?
>
> Seems OK? I'd rather have the trace points be self consistent than a mix
> of things spilling into pr_debug.
Exactly, but I wanted to be sure the community (and especially authors
of driver/infiniband/core/cm.c) agrees with this view.
I will follow up with a v2 this week with a few fixes and tweaks.
> If someone wants to debug the CM it is clearly better to use the
> complete set of tracepoints, right?
--
Chuck Lever
prev parent reply other threads:[~2020-07-20 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 14:06 [PATCH RFC 0/3] IB CM tracepoints Chuck Lever
2020-07-10 14:06 ` [PATCH RFC 1/3] RDMA/core: Move the rdma_show_ib_cm_event() macro Chuck Lever
2020-07-10 14:06 ` [PATCH RFC 2/3] RDMA/cm: Replace pr_debug() call sites with tracepoints Chuck Lever
2020-07-10 14:10 ` Chuck Lever
2020-07-10 14:06 ` [PATCH RFC 3/3] RDMA/cm: Add tracepoints to track MAD send operations Chuck Lever
2020-07-10 15:17 ` [PATCH RFC 0/3] IB CM tracepoints Jason Gunthorpe
2020-07-10 16:32 ` Chuck Lever
2020-07-20 14:00 ` Jason Gunthorpe
2020-07-20 14:05 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C478FD1F-CBA5-418B-B55D-37B5F4FF7408@oracle.com \
--to=chuck.lever@oracle.com \
--cc=aron.silverton@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).