linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 00/29] Possible NFSD patches for v5.8
Date: Wed, 20 May 2020 12:48:15 -0400	[thread overview]
Message-ID: <C607718F-3690-4147-B993-EC964FDCE4B9@oracle.com> (raw)
In-Reply-To: <20200520164639.GA19305@fieldses.org>



> On May 20, 2020, at 12:46 PM, Bruce Fields <bfields@fieldses.org> wrote:
> 
> On Tue, May 19, 2020 at 07:32:37PM -0400, Chuck Lever wrote:
>> Looks like python3 is now a requirement for pynfs, despite the comments
>> and code in nfs4.0/testserver.py.
>> 
>> Also, the README should explain that the server under test has to permit
>> access from insecure source ports (this still might not be the default
>> for some NFS servers).
> 
> Both done, thanks for the feedback.--b.
> 
> commit e4379b69becd
> Author: J. Bruce Fields <bfields@redhat.com>
> Date:   Wed May 20 12:43:33 2020 -0400
> 
>    Document high-port requirement for server testing
> 
>    Some NFS servers by default require the client to connect from a
>    low-numbered port.  But pynfs is meant to be runnable as a non-root
>    user, and as such can't necessarily get low-numbered ports.
> 
>    It might be useful to at least try to get a low-numbered port, or to
>    give a better error message.  For now, at least warn about this in the
>    README.
> 
>    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> 
> diff --git a/README b/README
> index 79cac62cb75e..a0236fb6b209 100644
> --- a/README
> +++ b/README
> @@ -18,6 +18,10 @@ For more details about 4.0 and 4.1 testing, see nfs4.0/README and
> nfs4.1/README, respectively.  For information about automatic code
> generation from an XDR file, see xdr/README.
> 
> +Note that any server under test must permit connections from high port
> +numbers.  (In the case of the NFS server, you can do this by adding
> +"insecure" to the export options.)

Thanks! One nit:

"In the case of the Linux NFS server"


> +
> Note that test results should *not* be considered authoritative
> statements about the protocol--if you find that a server fails a test,
> you should consult the rfc's and think carefully before assuming that
> 
> commit 39b62e990d84
> Author: J. Bruce Fields <bfields@redhat.com>
> Date:   Tue May 19 22:58:23 2020 -0400
> 
>    Fix comments and version checks that refer to python 2
> 
>    The minimum required version may actually be greater than 3.0, I'm not
>    sure.
> 
>    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> 
> diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py
> index cc509965f8e7..8f5ce26226d3 100644
> --- a/nfs4.0/lib/rpc/rpc.py
> +++ b/nfs4.0/lib/rpc/rpc.py
> @@ -1,6 +1,6 @@
> # rpc.py - based on RFC 1831
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.0/nfs4client.py b/nfs4.0/nfs4client.py
> index 5916dcc74139..37fbcbec9132 100755
> --- a/nfs4.0/nfs4client.py
> +++ b/nfs4.0/nfs4client.py
> @@ -9,8 +9,8 @@
> #
> 
> import sys
> -if sys.hexversion < 0x02070000:
> -    print("Requires python 2.7 or higher")
> +if sys.hexversion < 0x03000000:
> +    print("Requires python 3.0 or higher")
>     sys.exit(1)
> import os
> # Allow to be run stright from package root
> diff --git a/nfs4.0/nfs4lib.py b/nfs4.0/nfs4lib.py
> index 9adeb81daa95..82cec4b68cee 100644
> --- a/nfs4.0/nfs4lib.py
> +++ b/nfs4.0/nfs4lib.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/env python
> # nfs4lib.py - NFS4 library for Python
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.0/servertests/environment.py b/nfs4.0/servertests/environment.py
> index e7ef2b052833..edbd37a638a5 100644
> --- a/nfs4.0/servertests/environment.py
> +++ b/nfs4.0/servertests/environment.py
> @@ -1,7 +1,7 @@
> #
> # environment.py
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.0/testserver.py b/nfs4.0/testserver.py
> index 4f31f92a1e34..d380f2d5fe83 100755
> --- a/nfs4.0/testserver.py
> +++ b/nfs4.0/testserver.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/env python
> # nfs4stest.py - nfsv4 server tester
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> @@ -26,8 +26,8 @@
> 
> 
> import sys
> -if sys.hexversion < 0x02070000:
> -    print("Requires python 2.7 or higher")
> +if sys.hexversion < 0x03000000:
> +    print("Requires python 3.0 or higher")
>     sys.exit(1)
> import os
> # Allow to be run stright from package root
> diff --git a/nfs4.1/client41tests/environment.py b/nfs4.1/client41tests/environment.py
> index 25e7cb08ebb1..26d7368ebcb0 100644
> --- a/nfs4.1/client41tests/environment.py
> +++ b/nfs4.1/client41tests/environment.py
> @@ -1,7 +1,7 @@
> #
> # environment.py
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.1/server41tests/environment.py b/nfs4.1/server41tests/environment.py
> index e7bcaa90904c..b24862b61f08 100644
> --- a/nfs4.1/server41tests/environment.py
> +++ b/nfs4.1/server41tests/environment.py
> @@ -1,7 +1,7 @@
> #
> # environment.py
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.1/testclient.py b/nfs4.1/testclient.py
> index 19bd148edde2..3027419babd2 100755
> --- a/nfs4.1/testclient.py
> +++ b/nfs4.1/testclient.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/env python
> # nfs4stest.py - nfsv4 server tester
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> @@ -23,8 +23,8 @@
> 
> import use_local # HACK so don't have to rebuild constantly
> import sys
> -if sys.hexversion < 0x02070000:
> -    print("Requires python 2.7 or higher")
> +if sys.hexversion < 0x03000000:
> +    print("Requires python 3.0 or higher")
>     sys.exit(1)
> import os
> 
> diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py
> index 8c4ccdef5afa..0bf6bfc80fdc 100644
> --- a/nfs4.1/testmod.py
> +++ b/nfs4.1/testmod.py
> @@ -1,6 +1,6 @@
> # testmod.py - run tests from a suite
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> diff --git a/nfs4.1/testserver.py b/nfs4.1/testserver.py
> index f3fcfe9b8851..6b1157985be9 100755
> --- a/nfs4.1/testserver.py
> +++ b/nfs4.1/testserver.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/env python
> # nfs4stest.py - nfsv4 server tester
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 
> @@ -27,8 +27,8 @@
> 
> import use_local # HACK so don't have to rebuild constantly
> import sys
> -if sys.hexversion < 0x02070000:
> -    print("Requires python 2.7 or higher")
> +if sys.hexversion < 0x03000000:
> +    print("Requires python 3.0 or higher")
>     sys.exit(1)
> import os
> 
> diff --git a/showresults.py b/showresults.py
> index 0229a1e4d7b6..41d1c851721c 100755
> --- a/showresults.py
> +++ b/showresults.py
> @@ -1,7 +1,7 @@
> #!/usr/bin/env python
> # showresults.py - redisplay results from nfsv4 server tester output file
> #
> -# Requires python 2.7
> +# Requires python 3
> # 
> # Written by Fred Isaman <iisaman@citi.umich.edu>
> # Copyright (C) 2004 University of Michigan, Center for 

--
Chuck Lever




  reply	other threads:[~2020-05-20 16:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 21:22 [PATCH v2 00/29] Possible NFSD patches for v5.8 Chuck Lever
2020-05-12 21:22 ` [PATCH v2 01/29] SUNRPC: Move xpt_mutex into socket xpo_sendto methods Chuck Lever
2020-05-12 21:22 ` [PATCH v2 02/29] svcrdma: Clean up the tracing for rw_ctx_init errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 03/29] svcrdma: Clean up handling of get_rw_ctx errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 04/29] svcrdma: Trace page overruns when constructing RDMA Reads Chuck Lever
2020-05-12 21:22 ` [PATCH v2 05/29] svcrdma: trace undersized Write chunks Chuck Lever
2020-05-12 21:22 ` [PATCH v2 06/29] svcrdma: Fix backchannel return code Chuck Lever
2020-05-12 21:22 ` [PATCH v2 07/29] svcrdma: Remove backchannel dprintk call sites Chuck Lever
2020-05-12 21:22 ` [PATCH v2 08/29] svcrdma: Rename tracepoints that record header decoding errors Chuck Lever
2020-05-12 21:22 ` [PATCH v2 09/29] svcrdma: Remove the SVCRDMA_DEBUG macro Chuck Lever
2020-05-12 21:22 ` [PATCH v2 10/29] svcrdma: Displayed remote IP address should match stored address Chuck Lever
2020-05-12 21:23 ` [PATCH v2 11/29] svcrdma: Add tracepoints to report ->xpo_accept failures Chuck Lever
2020-05-12 21:23 ` [PATCH v2 12/29] SUNRPC: Remove kernel memory address from svc_xprt tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 13/29] SUNRPC: Tracepoint to record errors in svc_xpo_create() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 14/29] SUNRPC: Trace a few more generic svc_xprt events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 15/29] SUNRPC: Remove "#include <trace/events/skb.h>" Chuck Lever
2020-05-12 21:23 ` [PATCH v2 16/29] SUNRPC: Add more svcsock tracepoints Chuck Lever
2020-05-12 21:23 ` [PATCH v2 17/29] SUNRPC: Replace dprintk call sites in TCP state change callouts Chuck Lever
2020-05-12 21:23 ` [PATCH v2 18/29] SUNRPC: Trace server-side rpcbind registration events Chuck Lever
2020-05-12 21:23 ` [PATCH v2 19/29] SUNRPC: Rename svc_sock::sk_reclen Chuck Lever
2020-05-12 21:23 ` [PATCH v2 20/29] SUNRPC: Restructure svc_tcp_recv_record() Chuck Lever
2020-05-12 21:23 ` [PATCH v2 21/29] SUNRPC: Refactor svc_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 22/29] SUNRPC: Restructure svc_udp_recvfrom() Chuck Lever
2020-05-12 21:24 ` [PATCH v2 23/29] SUNRPC: svc_show_status() macro should have enum definitions Chuck Lever
2020-05-12 21:24 ` [PATCH v2 24/29] NFSD: Add tracepoints to NFSD's duplicate reply cache Chuck Lever
2020-05-12 21:24 ` [PATCH v2 25/29] NFSD: Add tracepoints to the NFSD state management code Chuck Lever
2020-05-12 21:24 ` [PATCH v2 26/29] NFSD: Add tracepoints for monitoring NFSD callbacks Chuck Lever
2020-05-12 21:24 ` [PATCH v2 27/29] SUNRPC: Clean up request deferral tracepoints Chuck Lever
2020-05-12 21:24 ` [PATCH v2 28/29] NFSD: Squash an annoying compiler warning Chuck Lever
2020-05-12 21:24 ` [PATCH v2 29/29] NFSD: Fix improperly-formatted Doxygen comments Chuck Lever
2020-05-19 16:11 ` [PATCH v2 00/29] Possible NFSD patches for v5.8 J. Bruce Fields
2020-05-19 16:14   ` Chuck Lever
2020-05-19 21:29     ` Bruce Fields
2020-05-19 22:25       ` Chuck Lever
2020-05-19 23:32         ` Chuck Lever
2020-05-20 16:46           ` Bruce Fields
2020-05-20 16:48             ` Chuck Lever [this message]
2020-05-20 17:01               ` Bruce Fields
2020-05-20 17:01             ` Calum Mackay
2020-05-20 17:14               ` Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C607718F-3690-4147-B993-EC964FDCE4B9@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).