From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT PULL] Please pull RDMA subsystem changes Date: Fri, 17 Aug 2018 13:50:05 -0700 Message-ID: References: <20180816215726.GA20526@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma , Linux Kernel Mailing List List-Id: linux-rdma@vger.kernel.org On Fri, Aug 17, 2018 at 12:44 PM Linus Torvalds wrote: > > Ok, everything but the max_sge thing was trivial. I just took yours. Oh, and doing the full test compile, I notice there are new warnings. That is *NOT* ok. The whole "x is deprecated" is not a useful warning. If you can't remove something, making it a reminder for yourself for later is not an acceptable excuse for bothering everybody else with the warning, and possibly having other issues hidden because by the time there are expected warnings, people will start ignoring the unexpected ones too. So "__deprecated" is for stuff that really isn't used any more, to catch possible new users. People have tried to use it for anything else, but it's always been a much bigger pain than it is worth. I've considered just removing the whole deprecation infrastructure. It has never really worked. Either its used, in which case deprecation warnings only hide real issues, or it's not used, in which case the function should just be removed. Linus