From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A128C432BE for ; Tue, 31 Aug 2021 15:57:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 000D760F25 for ; Tue, 31 Aug 2021 15:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239446AbhHaP6X (ORCPT ); Tue, 31 Aug 2021 11:58:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232770AbhHaP6W (ORCPT ); Tue, 31 Aug 2021 11:58:22 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75494C061575 for ; Tue, 31 Aug 2021 08:57:27 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id ia27so39896283ejc.10 for ; Tue, 31 Aug 2021 08:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r6f4uqoCFMIFa6l15nOd28gV+NZvn6A3PBp+lG5oRts=; b=aJK0CmHynnbo440M+s2PYpmbsQu70Cqw/tFFZ2KB9mmg8G99RVeZz2Oah6gb+SFPAj 5Ac0eD4T8rAK4CR3wyIL7JXgn6TmhCmyByHv4scSsiOl/sdg/fQcVYjJbALEAJnhSGk7 M19MyEKMs8QHgvBkJXA61zP6l2zQRoZqLpyOA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r6f4uqoCFMIFa6l15nOd28gV+NZvn6A3PBp+lG5oRts=; b=BYP0/9uZl4GpkwDlH9A5PaGFUu2U4RCtMsA6w2+c8EN5E+An6f0KgegQgMyEmStZxQ M0jcy7cketNRmMMcYbqdEnUzDZUW0iPQ4rU0vXdTemYSI3vJVqb8DAXwwHfdOKokI9/U wSrhaidIstJoRW426eV3P7PgBlYSTDR0vNLVABUOpBqqZQNNLN+9sDY1CA5veyxUnli/ oyfsBiSXXYTAPbxVbZe5b2Y27ljzOW62ZB6KjDVOZ8wHvmrqbsTrcmgtpvk8hTohNZBb HTaI0NUbQmfrn4neyv5mLINzbS1sz2axL7juydmLhN03h2S8EucpJNQEX7Nb7f3bnWZm xZWA== X-Gm-Message-State: AOAM532iXuNIh/YLlEU5ul+6onKrQ7PtnsrGWE/6rMiB9nBH2DKdc9uu cn9gI5Nlc7XhlEwUK3WzQePdzDnVmothhd+QoYM3UQ== X-Google-Smtp-Source: ABdhPJxx+Q85XoRbGXth3YrPXNeq13EsgrARnxPbpv9Fe2ftCjcLBXC55KHu5Csd2jT6c9jRVsAF25+VyJV/U2P4Xs8= X-Received: by 2002:a17:906:d94:: with SMTP id m20mr30969650eji.445.1630425445774; Tue, 31 Aug 2021 08:57:25 -0700 (PDT) MIME-Version: 1.0 References: <1630037738-20276-1-git-send-email-selvin.xavier@broadcom.com> <20210827123146.GH1200268@ziepe.ca> In-Reply-To: <20210827123146.GH1200268@ziepe.ca> From: Selvin Xavier Date: Tue, 31 Aug 2021 21:27:14 +0530 Message-ID: Subject: Re: [PATCH rdma-rc] RDMA/bnxt_re: Disable atomic support on VFs To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000008e1cf305cadd0188" Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org --0000000000008e1cf305cadd0188 Content-Type: text/plain; charset="UTF-8" On Fri, Aug 27, 2021 at 6:01 PM Jason Gunthorpe wrote: > > On Thu, Aug 26, 2021 at 09:15:38PM -0700, Selvin Xavier wrote: > > Following Host crash is observed when pci_enable_atomic_ops_to_root > > is called with VF PCI device. > > > > PID: 4481 TASK: ffff89c6941b0000 CPU: 53 COMMAND: "bash" > > #0 [ffff9a94817136d8] machine_kexec at ffffffffb90601a4 > > #1 [ffff9a9481713728] __crash_kexec at ffffffffb9190d5d > > #2 [ffff9a94817137f0] crash_kexec at ffffffffb9191c4d > > #3 [ffff9a9481713808] oops_end at ffffffffb9025cd6 > > #4 [ffff9a9481713828] page_fault_oops at ffffffffb906e417 > > #5 [ffff9a9481713888] exc_page_fault at ffffffffb9a0ad14 > > #6 [ffff9a94817138b0] asm_exc_page_fault at ffffffffb9c00ace > > [exception RIP: pcie_capability_read_dword+28] > > RIP: ffffffffb952fd5c RSP: ffff9a9481713960 RFLAGS: 00010246 > > RAX: 0000000000000001 RBX: ffff89c6b1096000 RCX: 0000000000000000 > > RDX: ffff9a9481713990 RSI: 0000000000000024 RDI: 0000000000000000 > > RBP: 0000000000000080 R8: 0000000000000008 R9: ffff89c64341a2f8 > > R10: 0000000000000002 R11: 0000000000000000 R12: ffff89c648bab000 > > R13: 0000000000000000 R14: 0000000000000000 R15: ffff89c648bab0c8 > > ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 > > #7 [ffff9a9481713988] pci_enable_atomic_ops_to_root at ffffffffb95359a6 > > #8 [ffff9a94817139c0] bnxt_qplib_determine_atomics at ffffffffc08c1a33 [bnxt_re] > > #9 [ffff9a94817139d0] bnxt_re_dev_init at ffffffffc08ba2d1 [bnxt_re] > > RIP: 00007f450602f648 RSP: 00007ffe880869e8 RFLAGS: 00000246 > > RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 00007f450602f648 > > RDX: 0000000000000002 RSI: 0000555c566c4a60 RDI: 0000000000000001 > > RBP: 0000555c566c4a60 R8: 000000000000000a R9: 00007f45060c2580 > > R10: 000000000000000a R11: 0000000000000246 R12: 00007f45063026e0 > > R13: 0000000000000002 R14: 00007f45062fd880 R15: 0000000000000002 > > ORIG_RAX: 0000000000000001 CS: 0033 SS: 002b > Apologies for the delay in my response. I was exploring internally to see if it is a specific issue with the adapter/host. I see the problem in multiple systems. > This feels like a bug in pci_enable_atomic_ops_to_root()? I assume it > hit a case where bus->self == NULL? yes. This crashes because of bus->self is NULL. Is it expected for VF? > > Why not fix it there? Since its a functional breakage in 5.14, I posted a quick fix for 5.14. Also, we haven't done any testing on VF for this feature. So I wanted to avoid claiming support for VF anyway. I see that other drivers also use pci_enable_atomic_ops_to_root without vf/pf check. Anyone seeing this issue? > > Jason --0000000000008e1cf305cadd0188 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQfAYJKoZIhvcNAQcCoIIQbTCCEGkCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3TMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVswggRDoAMCAQICDF5r4Y1hK+0xlnInPDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjNaFw0yMjA5MjIxNDUxNDZaMIGc MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xIjAgBgNVBAMTGVNlbHZpbiBUaHlwYXJhbXBpbCBYYXZpZXIx KTAnBgkqhkiG9w0BCQEWGnNlbHZpbi54YXZpZXJAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0B AQEFAAOCAQ8AMIIBCgKCAQEAxUvDzFRYD8BTJrAMQdCDuIfwWINjz4kZW2bdRd3xs/PuwwulZFR9 IqmPAgBjM5dcqFtbSHi+/g+LZBMw6k/LfLLK02KsorxgMOZVCIOVCuM4Nj0vrIwtMJ+fNnaa6Dvu a85G89a0sBrN3Y6hDnOfpbimSOgwA82EFWkGY4VggzfB7w1rhwu515LAm0sN0WOsrGP7QI8ZJr8g od7PzGNQ3SgTYKl5XslMq+gpy+K8+egxMxo3D07c8snwyfU7Y7NQ8I1M986gsj9RUcp3oo0N+T1W rwVchQXTGD/Hwqc11XBU1H3JKSRkn7cTa9bMFnp0Asr3Y4/kB+4t6PhYi50ORwIDAQABo4IB2zCC AdcwDgYDVR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDov L3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAu Y3J0MEEGCCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29u YWxzaWduMmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0 cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBA MD6gPKA6hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2Ey MDIwLmNybDAlBgNVHREEHjAcgRpzZWx2aW4ueGF2aWVyQGJyb2FkY29tLmNvbTATBgNVHSUEDDAK BggrBgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQU6uPX 5eOTTGwUwIAAoXKF4qVZLfgwDQYJKoZIhvcNAQELBQADggEBAKAn7gHcWCrqvZPX7lw4FJEOMJ2s cPoLqoiJLhVttehI3r8nFmNe5WanBDnClSbn1WMa5fHtttEjxZkHOFZqWLHYRI/hnXtVBjF9YV/1 Hs3HTO02pYpYyHue4CSXgBtj45ZVZ0FjQNxgoLFvJOq3iSsy/tS2uVH5Pe1AW495cxp8+p5b3VGe HRzGet524jE0vZx0A/6qrYo6C7z4Djrt/QU2MZDbPb+kwkkomwcn0Nvr91KWSrbhhHtZ/EfXi08L x3R3oHtWjbmIW1nYkwVk4pQZoaLkRWkfTSGpwDwilhrd2F+d5rhCbAbfACk4Oly51GV4SI7jUm0D VbZWyuIx85gxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWdu IG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIw Agxea+GNYSvtMZZyJzwwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIMkWL4BugK18 b4bLjmMpJ7lXX71CS3/dZT7YhHyTls2UMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIxMDgzMTE1NTcyNlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJ YIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcN AQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQCDQYOdDWQ58G9mxDlwF4XyChUl/NZl JSQmkXvdHutvB0NoqLFN4aaM9e/4Sqahmme3wwTyxcE8mrh9eUE9sySAcsXHwu1cIf0PW/XD2d7h FlwG/6nkweP4vniWRqgHpuBrwk9/RDe0JAjI981zRF7eZojRoPzTlYhttB6F4diF2GGa0gs99rnF S1cq/pfI60MfaeOorrF7r1dX9AA8iIfM4/Azcn3xF2aandCvodlmeb0xJye/Jom1OkuguAeve6kh mnN2ZW8TR6PrtT7i/zFxy4u8K+/tOJVig56t7HiNfsKfpo8zrWhnClSmP/rYToC8PCCiQ8MJIQeH EnvJ9f1T --0000000000008e1cf305cadd0188--