linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Selvin Xavier <selvin.xavier@broadcom.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 07/12] RDMA/bnxt_re: Fix query SRQ failure
Date: Mon, 13 Sep 2021 16:40:52 +0530	[thread overview]
Message-ID: <CA+sbYW37rqodaqgG4_w1fA=p1QT44OMv7nGuRn=3yPx6FtLZNQ@mail.gmail.com> (raw)
In-Reply-To: <YT8uNPMzuLsBlOTd@unreal>

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

On Mon, Sep 13, 2021 at 4:25 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Sun, Sep 12, 2021 at 11:15:21AM -0700, Selvin Xavier wrote:
> > Fill the missing parameters for the FW command while
> > querying SRQ.
> >
> > Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters")
> > Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
> > ---
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > index 539b1a2..e2926dd 100644
> > --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
> > @@ -713,6 +713,8 @@ int bnxt_qplib_query_srq(struct bnxt_qplib_res *res,
> >       sbuf = bnxt_qplib_rcfw_alloc_sbuf(rcfw, sizeof(*sb));
> >       if (!sbuf)
> >               return -ENOMEM;
> > +     req.resp_size = sizeof(*sb) / BNXT_QPLIB_CMDQE_UNITS;
> > +     req.srq_cid = cpu_to_le32(srq->id);
>
> You already have this line.

ok.. I will remove one of them. mainly the fix was for the resp_size..

Thanks
>
>    698 int bnxt_qplib_query_srq(struct bnxt_qplib_res *res,
>    699                          struct bnxt_qplib_srq *srq)
>    700 {
>    ...
>    708
>    709         RCFW_CMD_PREP(req, QUERY_SRQ, cmd_flags);
>    710         req.srq_cid = cpu_to_le32(srq->id);
>
>
> >       sb = sbuf->sb;
> >       rc = bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> >                                         (void *)sbuf, 0);
> > --
> > 2.5.5
> >

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4224 bytes --]

  reply	other threads:[~2021-09-13 11:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 18:15 [PATCH for-next 00/12] RDMA/bnxt_re: Driver update Selvin Xavier
2021-09-12 18:15 ` [PATCH for-next 01/12] RDMA/bnxt_re: Add extended statistics counters Selvin Xavier
2021-09-13 10:45   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 02/12] RDMA/bnxt_re: Update statistics counter name Selvin Xavier
2021-09-13 10:45   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 03/12] RDMA/bnxt_re: Use separate response buffer for stat_ctx_free Selvin Xavier
2021-09-13 10:46   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 04/12] RDMA/bnxt_re: Reduce the delay in polling for hwrm command completion Selvin Xavier
2021-09-13 10:49   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 05/12] RDMA/bnxt_re: Support multiple page sizes Selvin Xavier
2021-09-13 10:51   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 06/12] RDMA/bnxt_re: Suppress unwanted error messages Selvin Xavier
2021-09-13 10:52   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 07/12] RDMA/bnxt_re: Fix query SRQ failure Selvin Xavier
2021-09-13 10:55   ` Leon Romanovsky
2021-09-13 11:10     ` Selvin Xavier [this message]
2021-09-12 18:15 ` [PATCH for-next 08/12] RDMA/bnxt_re: Fix FRMR issue with single page MR allocation Selvin Xavier
2021-09-13 10:57   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 09/12] RDMA/bnxt_re: Use GFP_KERNEL in non atomic context Selvin Xavier
2021-09-13 11:10   ` Leon Romanovsky
2021-09-13 11:15     ` Selvin Xavier
2021-09-12 18:15 ` [PATCH for-next 10/12] RDMA/bnxt_re: Correct FRMR size calculation Selvin Xavier
2021-09-13 11:11   ` Leon Romanovsky
2021-09-12 18:15 ` [PATCH for-next 11/12] RDMA/bnxt_re: Check if the vlan is valid before reporting Selvin Xavier
2021-09-12 18:15 ` [PATCH for-next 12/12] MAINTAINERS: Update Broadcom RDMA maintainers Selvin Xavier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+sbYW37rqodaqgG4_w1fA=p1QT44OMv7nGuRn=3yPx6FtLZNQ@mail.gmail.com' \
    --to=selvin.xavier@broadcom.com \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).