From: Stephen Rust <srust@blockbridge.com> To: Sagi Grimberg <sagi@grimberg.me> Cc: Ming Lei <ming.lei@redhat.com>, Rob Townley <rob.townley@gmail.com>, Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, target-devel@vger.kernel.org, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Max Gurtovoy <maxg@mellanox.com> Subject: Re: Data corruption in kernel 5.1+ with iSER attached ramdisk Date: Thu, 5 Dec 2019 09:36:25 -0500 Message-ID: <CAAFE1bcgKAuzmE+eYXvcj6y4SykoaWfXgzR+f2N73K_2RfZ6LA@mail.gmail.com> (raw) In-Reply-To: <d9d39d10-d3f3-f2d8-b32e-96896ba0cdb2@grimberg.me> Hi Sagi, On Thu, Dec 5, 2019 at 4:17 AM Sagi Grimberg <sagi@grimberg.me> wrote: > > Just got this one (Thanks for CCing me Ming, been extremely busy > lately). No problem, thanks for looking into it! > So it looks from the report that this is the immediate-data and > unsolicited data-out flows, which indeed seem to violate the alignment > assumption. The reason is that isert post recv a contig rx_desc which > has both the headers and the data, and when it gets immediate_data it > will set the data sg to rx_desc+offset (which are the headers). > > Stephen, > As a work-around for now, you should turn off immediate-data in your LIO > target. I'll work on a fix. I have confirmed that turning off ImmediateData in the target (and reconnecting) is a successful workaround for this test case. All of the I/O as reported by bio_add_page() is aligned. Using the previously described bpftrace script with 512 offset: # bpftrace lio.bt Attaching 4 probes... 512 0 512 0 1 131071 4096 0 4096 0 0 0 4096 0 4096 0 0 8 4096 0 4096 0 0 131064 4096 0 4096 0 1 131064 4096 0 4096 0 0 0 4096 0 4096 0 0 8 512 0 512 0 0 131071 4096 0 4096 0 0 130944 4096 0 4096 0 0 131056 > Thanks for reporting! Please let me know if you need any additional information, or if I can assist further. I would be happy to test any patches when you are ready. Thanks, Steve
next prev parent reply index Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CAAFE1bd9wuuobpe4VK7Ty175j7mWT+kRmHCNhVD+6R8MWEAqmw@mail.gmail.com> 2019-11-28 1:57 ` Ming Lei [not found] ` <CA+VdTb_-CGaPjKUQteKVFSGqDz-5o-tuRRkJYqt8B9iOQypiwQ@mail.gmail.com> 2019-11-28 2:58 ` Ming Lei [not found] ` <CAAFE1bfsXsKGyw7SU_z4NanT+wmtuJT=XejBYbHHMCDQwm73sw@mail.gmail.com> 2019-11-28 4:25 ` Stephen Rust 2019-11-28 5:51 ` Rob Townley 2019-11-28 9:12 ` Ming Lei 2019-12-02 18:42 ` Stephen Rust 2019-12-03 0:58 ` Ming Lei 2019-12-03 3:04 ` Stephen Rust 2019-12-03 3:14 ` Ming Lei 2019-12-03 3:26 ` Stephen Rust 2019-12-03 3:50 ` Stephen Rust 2019-12-03 12:45 ` Ming Lei 2019-12-03 19:56 ` Stephen Rust 2019-12-04 1:05 ` Ming Lei 2019-12-04 17:23 ` Stephen Rust 2019-12-04 23:02 ` Ming Lei 2019-12-05 0:16 ` Bart Van Assche 2019-12-05 14:44 ` Stephen Rust 2019-12-05 2:28 ` Stephen Rust 2019-12-05 3:05 ` Ming Lei 2019-12-05 9:17 ` Sagi Grimberg 2019-12-05 14:36 ` Stephen Rust [this message] [not found] ` <CAAFE1beqFBQS_zVYEXFTD2qu8PAF9hBSW4j1k9ZD6MhU_gWg5Q@mail.gmail.com> 2020-03-25 0:15 ` Sagi Grimberg 2020-03-30 17:08 ` Stephen Rust 2020-03-31 1:07 ` Sagi Grimberg 2020-04-01 0:38 ` Sagi Grimberg 2020-04-02 20:03 ` Stephen Rust 2020-04-02 22:16 ` Sagi Grimberg 2019-12-04 2:39 ` Ming Lei 2019-12-03 4:15 ` Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAFE1bcgKAuzmE+eYXvcj6y4SykoaWfXgzR+f2N73K_2RfZ6LA@mail.gmail.com \ --to=srust@blockbridge.com \ --cc=axboe@kernel.dk \ --cc=dledford@redhat.com \ --cc=hch@lst.de \ --cc=jgg@ziepe.ca \ --cc=linux-block@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=maxg@mellanox.com \ --cc=ming.lei@redhat.com \ --cc=rob.townley@gmail.com \ --cc=sagi@grimberg.me \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-RDMA Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \ linux-rdma@vger.kernel.org public-inbox-index linux-rdma Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma AGPL code for this site: git clone https://public-inbox.org/public-inbox.git