From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F500C76192 for ; Wed, 17 Jul 2019 13:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4070F20818 for ; Wed, 17 Jul 2019 13:37:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jU/Zat9i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbfGQNhB (ORCPT ); Wed, 17 Jul 2019 09:37:01 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:35396 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727935AbfGQNgu (ORCPT ); Wed, 17 Jul 2019 09:36:50 -0400 Received: by mail-pf1-f193.google.com with SMTP id u14so10873928pfn.2 for ; Wed, 17 Jul 2019 06:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=upJur9hX33jRa5ZDAABYWCcVNIU4OKrA323sUj0kiJ0=; b=jU/Zat9i+mrs8cSnCYXrBiEONUz0WXxyKyOECIIPiTvG8WEhtGZGjK61290IX8o36U OrHTHQ7Woyg/qn3+sukX8RWKFmT/Ab3vSFlM0FM2BRuiucJNWXV94DF4e2NhGQgdA44A dT08TPfZUZgkz0of54cXYItyNEHlQbHBkArsYbqcDoUXDHAB+kz50O9ewS939NtAQV8u N3pg+MG4dZM9J1oQTBELA9KEuGXZuE94dTh2nx4VJ6oW11nUXuKKdq/o5lVXbnas7dEB 7eGFT9GZTTNoP+bU6YviC4h7qnZidfElkMDjIpsDOMoPQb/nzifgWXLs7MlD24BgMlQq Xslw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=upJur9hX33jRa5ZDAABYWCcVNIU4OKrA323sUj0kiJ0=; b=Te2tGPi0aVa/5f2k3gNAiASn9cEq3hzMVDDHmKy2or4KwOE2s31vjBdBpHxm8Mw1Xy Ld0F0YhBDg1CGKLpWGcHh9XDOXvwlv6bsqZPKDt4QvbANtyvMMkM0dQotVyqb1x950Wr OcceFO6Q7bH71zFwBU6hOlIsoHNlNCPhpum1X4SCgxdxTQHI72guaIP95QmhLCX4Eqrl OTynLk7MLbqozo0NdYVaVzrcmWnsmpV4U7uLv/WqaJ2fnON2bpkcFEjGMY9oKhXlOfaH s48MH+nZK4Ghwn7l1C6l3QZyPFbCYrBM5Kt0qIQopsSWBN1JSqJWgUoPpsykUM1aoR5f VPlw== X-Gm-Message-State: APjAAAVFQ9VG3z6bgdmRv1Vc//EuBqCc+yNFdpQc2JbRiuanigEsQ9/O ej8wYlJWPslx9xLASnOuz+JNyiu8ANiE8Yq+cm+IQg== X-Google-Smtp-Source: APXvYqz7m/UfmCxQEvGyEZmLKWfGDEQqrP2qzxF/oMVv3Ek5NDX+f4ncbRdtOgqzhkxO4Lp3vwbZe7MPyGJ1vZM4Wx0= X-Received: by 2002:a17:90a:2488:: with SMTP id i8mr43162554pje.123.1563370608796; Wed, 17 Jul 2019 06:36:48 -0700 (PDT) MIME-Version: 1.0 References: <20190624174015.GL29120@arrakis.emea.arm.com> <20190715180510.GC4970@ziepe.ca> <20190716120624.GA29727@ziepe.ca> <20190717115828.GE12119@ziepe.ca> In-Reply-To: <20190717115828.GE12119@ziepe.ca> From: Andrey Konovalov Date: Wed, 17 Jul 2019 15:36:37 +0200 Message-ID: Subject: Re: [PATCH v18 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr To: Jason Gunthorpe Cc: Linux ARM , Linux Memory Management List , LKML , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, kvm@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Vincenzo Frascino , Will Deacon , Mark Rutland , Andrew Morton , Greg Kroah-Hartman , Kees Cook , Yishai Hadas , Felix Kuehling , Alexander Deucher , Christian Koenig , Mauro Carvalho Chehab , Jens Wiklander , Alex Williamson , Leon Romanovsky , Luc Van Oostenryck , Dave Martin , Khalid Aziz , enh , Christoph Hellwig , Dmitry Vyukov , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Robin Murphy , Kevin Brodsky , Szabolcs Nagy , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jul 17, 2019 at 1:58 PM Jason Gunthorpe wrote: > > On Wed, Jul 17, 2019 at 01:44:07PM +0200, Andrey Konovalov wrote: > > On Tue, Jul 16, 2019 at 2:06 PM Jason Gunthorpe wrote: > > > > > > On Tue, Jul 16, 2019 at 12:42:07PM +0200, Andrey Konovalov wrote: > > > > On Mon, Jul 15, 2019 at 8:05 PM Jason Gunthorpe wrote: > > > > > > > > > > On Mon, Jul 15, 2019 at 06:01:29PM +0200, Andrey Konovalov wrote: > > > > > > On Mon, Jun 24, 2019 at 7:40 PM Catalin Marinas wrote: > > > > > > > > > > > > > > On Mon, Jun 24, 2019 at 04:32:56PM +0200, Andrey Konovalov wrote: > > > > > > > > This patch is a part of a series that extends kernel ABI to allow to pass > > > > > > > > tagged user pointers (with the top byte set to something else other than > > > > > > > > 0x00) as syscall arguments. > > > > > > > > > > > > > > > > mlx4_get_umem_mr() uses provided user pointers for vma lookups, which can > > > > > > > > only by done with untagged pointers. > > > > > > > > > > > > > > > > Untag user pointers in this function. > > > > > > > > > > > > > > > > Signed-off-by: Andrey Konovalov > > > > > > > > drivers/infiniband/hw/mlx4/mr.c | 7 ++++--- > > > > > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > > > > > > > This patch also needs an ack from the infiniband maintainers (Jason). > > > > > > > > > > > > Hi Jason, > > > > > > > > > > > > Could you take a look and give your acked-by? > > > > > > > > > > Oh, I think I did this a long time ago. Still looks OK. > > > > > > > > Hm, maybe that was we who lost it. Thanks! > > > > > > > > > You will send it? > > > > > > > > I will resend the patchset once the merge window is closed, if that's > > > > what you mean. > > > > > > No.. I mean who send it to Linus's tree? ie do you want me to take > > > this patch into rdma? > > > > I think the plan was to merge the whole series through the mm tree. > > But I don't mind if you want to take this patch into your tree. It's > > just that this patch doesn't make much sense without the rest of the > > series. > > Generally I prefer if subsystem changes stay in subsystem trees. If > the patch is good standalone, and the untag API has already been > merged, this is a better strategy. OK, feel free to take this into your tree, this works for me. > > Jason