Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()
@ 2021-04-21  3:59 Bob Pearson
  2021-04-21  5:38 ` Zhu Yanjun
  2021-04-21 19:17 ` Jason Gunthorpe
  0 siblings, 2 replies; 3+ messages in thread
From: Bob Pearson @ 2021-04-21  3:59 UTC (permalink / raw)
  To: jgg, zyjzyj2000, linux-rdma; +Cc: Bob Pearson, Frank Zago

Fix a bug in rxe_fill_ip_info() which was attempting to convert from
RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
not .._IPV4.

Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
Suggested-by: Frank Zago <frank.zago@hpe.com>
Signed-off-by: Bob Pearson <rpearson@hpe.com>
---
 drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
index df0d173d6acb..da2e867a1ed9 100644
--- a/drivers/infiniband/sw/rxe/rxe_av.c
+++ b/drivers/infiniband/sw/rxe/rxe_av.c
@@ -88,7 +88,7 @@ void rxe_av_fill_ip_info(struct rxe_av *av, struct rdma_ah_attr *attr)
 		type = RXE_NETWORK_TYPE_IPV4;
 		break;
 	case RDMA_NETWORK_IPV6:
-		type = RXE_NETWORK_TYPE_IPV4;
+		type = RXE_NETWORK_TYPE_IPV6;
 		break;
 	default:
 		/* not reached - checked in rxe_av_chk_attr */
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()
  2021-04-21  3:59 [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info() Bob Pearson
@ 2021-04-21  5:38 ` Zhu Yanjun
  2021-04-21 19:17 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu Yanjun @ 2021-04-21  5:38 UTC (permalink / raw)
  To: Bob Pearson; +Cc: Jason Gunthorpe, RDMA mailing list, Bob Pearson, Frank Zago

Thanks.

Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

On Wed, Apr 21, 2021 at 12:01 PM Bob Pearson <rpearsonhpe@gmail.com> wrote:
>
> Fix a bug in rxe_fill_ip_info() which was attempting to convert from
> RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
> not .._IPV4.
>
> Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
> Suggested-by: Frank Zago <frank.zago@hpe.com>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
> index df0d173d6acb..da2e867a1ed9 100644
> --- a/drivers/infiniband/sw/rxe/rxe_av.c
> +++ b/drivers/infiniband/sw/rxe/rxe_av.c
> @@ -88,7 +88,7 @@ void rxe_av_fill_ip_info(struct rxe_av *av, struct rdma_ah_attr *attr)
>                 type = RXE_NETWORK_TYPE_IPV4;
>                 break;
>         case RDMA_NETWORK_IPV6:
> -               type = RXE_NETWORK_TYPE_IPV4;
> +               type = RXE_NETWORK_TYPE_IPV6;
>                 break;
>         default:
>                 /* not reached - checked in rxe_av_chk_attr */
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()
  2021-04-21  3:59 [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info() Bob Pearson
  2021-04-21  5:38 ` Zhu Yanjun
@ 2021-04-21 19:17 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-04-21 19:17 UTC (permalink / raw)
  To: Bob Pearson; +Cc: zyjzyj2000, linux-rdma, Bob Pearson, Frank Zago

On Tue, Apr 20, 2021 at 10:59:53PM -0500, Bob Pearson wrote:
> Fix a bug in rxe_fill_ip_info() which was attempting to convert from
> RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
> not .._IPV4.
> 
> Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
> Suggested-by: Frank Zago <frank.zago@hpe.com>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21  3:59 [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info() Bob Pearson
2021-04-21  5:38 ` Zhu Yanjun
2021-04-21 19:17 ` Jason Gunthorpe

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git