[PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()

[PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()

[Bob Pearson]

Fix a bug in rxe_fill_ip_info() which was attempting to convert from
RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
not .._IPV4.

Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
Suggested-by: Frank Zago <frank.zago@hpe.com>
Signed-off-by: Bob Pearson <rpearson@hpe.com>
---
 drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
index df0d173d6acb..da2e867a1ed9 100644
--- a/drivers/infiniband/sw/rxe/rxe_av.c
+++ b/drivers/infiniband/sw/rxe/rxe_av.c
@@ -88,7 +88,7 @@ void rxe_av_fill_ip_info(struct rxe_av *av, struct rdma_ah_attr *attr)
 		type = RXE_NETWORK_TYPE_IPV4;
 		break;
 	case RDMA_NETWORK_IPV6:
-		type = RXE_NETWORK_TYPE_IPV4;
+		type = RXE_NETWORK_TYPE_IPV6;
 		break;
 	default:
 		/* not reached - checked in rxe_av_chk_attr */
-- 
2.27.0

Re: [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()

[Zhu Yanjun]

Thanks.

Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

On Wed, Apr 21, 2021 at 12:01 PM Bob Pearson <rpearsonhpe@gmail.com> wrote:
>
> Fix a bug in rxe_fill_ip_info() which was attempting to convert from
> RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
> not .._IPV4.
>
> Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
> Suggested-by: Frank Zago <frank.zago@hpe.com>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
> index df0d173d6acb..da2e867a1ed9 100644
> --- a/drivers/infiniband/sw/rxe/rxe_av.c
> +++ b/drivers/infiniband/sw/rxe/rxe_av.c
> @@ -88,7 +88,7 @@ void rxe_av_fill_ip_info(struct rxe_av *av, struct rdma_ah_attr *attr)
>                 type = RXE_NETWORK_TYPE_IPV4;
>                 break;
>         case RDMA_NETWORK_IPV6:
> -               type = RXE_NETWORK_TYPE_IPV4;
> +               type = RXE_NETWORK_TYPE_IPV6;
>                 break;
>         default:
>                 /* not reached - checked in rxe_av_chk_attr */
> --
> 2.27.0
>

Re: [PATCH for-next] RDMA/rxe: Fix a bug in rxe_fill_ip_info()

[Jason Gunthorpe]

On Tue, Apr 20, 2021 at 10:59:53PM -0500, Bob Pearson wrote:
> Fix a bug in rxe_fill_ip_info() which was attempting to convert from
> RDMA_NETWORK_XXX to RXE_NETWORK_XXX. .._IPV6 should have mapped to .._IPV6
> not .._IPV4.
> 
> Fixes: edebc8407b88 ("RDMA/rxe: Fix small problem in network_type patch")
> Suggested-by: Frank Zago <frank.zago@hpe.com>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason