From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: linux-rdma@vger.kernel.org, Zhu Yanjun <yanjunz@mellanox.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-next] RDMA/rxe: Remove unused rxe_mem_map_pages
Date: Mon, 22 Jun 2020 17:52:35 +0800 [thread overview]
Message-ID: <CAD=hENe62hemUGm6m_ecp_RH5qMYua5d8F=1Lxuh6mob8xe5Pg@mail.gmail.com> (raw)
In-Reply-To: <20200622093131.9238-1-kamalheib1@gmail.com>
On Mon, Jun 22, 2020 at 5:32 PM Kamal Heib <kamalheib1@gmail.com> wrote:
>
> This function is not in use - delete it.
>
Add:
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Is it better?
Zhu Yanjun
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_loc.h | 3 --
> drivers/infiniband/sw/rxe/rxe_mr.c | 44 -----------------------------
> 2 files changed, 47 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h
> index 775c23becaec..238d6a357aac 100644
> --- a/drivers/infiniband/sw/rxe/rxe_loc.h
> +++ b/drivers/infiniband/sw/rxe/rxe_loc.h
> @@ -132,9 +132,6 @@ struct rxe_mem *lookup_mem(struct rxe_pd *pd, int access, u32 key,
>
> int mem_check_range(struct rxe_mem *mem, u64 iova, size_t length);
>
> -int rxe_mem_map_pages(struct rxe_dev *rxe, struct rxe_mem *mem,
> - u64 *page, int num_pages, u64 iova);
> -
> void rxe_mem_cleanup(struct rxe_pool_entry *arg);
>
> int advance_dma_data(struct rxe_dma_info *dma, unsigned int length);
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index e83c7b518bfa..a63cb5fac01f 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -587,47 +587,3 @@ struct rxe_mem *lookup_mem(struct rxe_pd *pd, int access, u32 key,
>
> return mem;
> }
> -
> -int rxe_mem_map_pages(struct rxe_dev *rxe, struct rxe_mem *mem,
> - u64 *page, int num_pages, u64 iova)
> -{
> - int i;
> - int num_buf;
> - int err;
> - struct rxe_map **map;
> - struct rxe_phys_buf *buf;
> - int page_size;
> -
> - if (num_pages > mem->max_buf) {
> - err = -EINVAL;
> - goto err1;
> - }
> -
> - num_buf = 0;
> - page_size = 1 << mem->page_shift;
> - map = mem->map;
> - buf = map[0]->buf;
> -
> - for (i = 0; i < num_pages; i++) {
> - buf->addr = *page++;
> - buf->size = page_size;
> - buf++;
> - num_buf++;
> -
> - if (num_buf == RXE_BUF_PER_MAP) {
> - map++;
> - buf = map[0]->buf;
> - num_buf = 0;
> - }
> - }
> -
> - mem->iova = iova;
> - mem->va = iova;
> - mem->length = num_pages << mem->page_shift;
> - mem->state = RXE_MEM_STATE_VALID;
> -
> - return 0;
> -
> -err1:
> - return err;
> -}
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-06-22 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 9:31 [PATCH for-next] RDMA/rxe: Remove unused rxe_mem_map_pages Kamal Heib
2020-06-22 9:52 ` Zhu Yanjun [this message]
2020-06-22 10:03 ` Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=hENe62hemUGm6m_ecp_RH5qMYua5d8F=1Lxuh6mob8xe5Pg@mail.gmail.com' \
--to=zyjzyj2000@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjunz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).